Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SSR-compatible slot implementation in TreeView #3097

Merged
merged 5 commits into from
Mar 31, 2023
Merged

Use SSR-compatible slot implementation in TreeView #3097

merged 5 commits into from
Mar 31, 2023

Conversation

colebemis
Copy link
Contributor

@colebemis colebemis commented Mar 30, 2023 •
edited
Loading

Swaps out the underlying slots implementation for TreeView.LeadingVisual and TreeView.TrailingVisual.

See #1690 for more context.

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 3cc1985

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 95.04 KB (-0.06% 🔽)
dist/browser.umd.js 95.58 KB (-0.06% 🔽)

@colebemis colebemis mentioned this pull request Mar 30, 2023
Closed
10 tasks
@github-actions github-actions bot temporarily deployed to storybook-preview-3097 March 30, 2023 16:40 Inactive
@primer primer bot temporarily deployed to github-pages March 30, 2023 16:40 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3097 March 30, 2023 16:41 Inactive
@colebemis colebemis temporarily deployed to github-pages March 30, 2023 17:53 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3097 March 30, 2023 17:53 Inactive
@colebemis colebemis marked this pull request as ready for review March 30, 2023 18:04
@colebemis colebemis requested review from a team and josepmartins March 30, 2023 18:04
@colebemis colebemis temporarily deployed to github-pages March 30, 2023 18:18 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3097 March 30, 2023 18:19 Inactive
mperrotti
mperrotti approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@mperrotti mperrotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any new tests we should write to test the SSR compatibility? If not, LGTM!

These changes look great, and everything looks good in Storybook. However, I didn't test the SSR compatibility because I'm not sure how to in this repo.

@colebemis
Copy link
Contributor Author

Are there any new tests we should write to test the SSR compatibility? If not, LGTM!

These changes look great, and everything looks good in Storybook. However, I didn't test the SSR compatibility because I'm not sure how to in this repo.

We have tests to ensure useSlots work as expected. I don't think it's necessary to explicitly test that functionality in TreeView.

@colebemis colebemis added this pull request to the merge queue Mar 31, 2023
Merged via the queue into main with commit a38c00e Mar 31, 2023
@colebemis colebemis deleted the treeview-slots branch March 31, 2023 19:35
@primer-css primer-css mentioned this pull request Mar 31, 2023
Merged
@primer-css primer-css mentioned this pull request Apr 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mperrotti mperrotti mperrotti approved these changes

@josepmartins josepmartins Awaiting requested review from josepmartins

@siddharthkp siddharthkp Awaiting requested review from siddharthkp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colebemis @mperrotti