Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font weight bold for ActionList.Item with inline description #3170

Merged
merged 4 commits into from
Apr 14, 2023

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Apr 14, 2023

When an inline description is added to the item the normal text gets bold. This is how it is designed and specified in the docs: https://primer.style/design/components/action-list

Screenshots

Before After
Screenshot 2023-04-14 at 08 50 43 Screenshot 2023-04-14 at 08 50 51

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2023

🦋 Changeset detected

Latest commit: ff6c5a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 95.88 KB (+0.02% 🔺)
dist/browser.umd.js 96.48 KB (+0.02% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-3170 April 14, 2023 06:58 Inactive
@lukasoppermann lukasoppermann self-assigned this Apr 14, 2023
@lukasoppermann lukasoppermann temporarily deployed to github-pages April 14, 2023 07:01 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3170 April 14, 2023 07:01 Inactive
src/ActionList/Item.tsx Outdated Show resolved Hide resolved
Co-authored-by: Cole Bemis <colebemis@github.com>
@lukasoppermann lukasoppermann temporarily deployed to github-pages April 14, 2023 07:32 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3170 April 14, 2023 07:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants