-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figma connect files #4681
Figma connect files #4681
Conversation
|
size-limit report 📦
|
8b2dfa6
to
93a8fd7
Compare
b9e6024
to
a570d30
Compare
08f72ee
to
571394f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍 Just left a question about the ESLint errors popping up and also saw that some of the files have TS errors in CI. Let me know if I can help out at all with those!
Hey @joshblack I think we need to disable the type check for those files, or do you know how we can fix it? We can't add an |
571394f
to
1241a88
Compare
@lukasoppermann just pushed up a commit to get TypeScript ✅ (hope that's okay, let me know if not!) Let me know if that matches what you were thinking for these components or not 👀 |
}), | ||
counter: figma.boolean('counter?', { | ||
false: undefined, | ||
true: figma.children('CounterLabel'), | ||
true: figma.string('CounterLabel'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be reverted, we need children here.
<UnderlineNav.Item | ||
aria-current={current} | ||
counter={counter} | ||
icon={leadingVisual ? () => leadingVisual : undefined} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not work I think as the code is not executed. But I'll check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, it does not work and moving it to the figma.boolean section also does not.
I reached out to Figma for this.
This reverts commit 0cdec4b.
@lukasoppermann I'll revert the commit based on your comments 👍 I'll add more info here for where the changes came from.
The type error is because
The type error here is that the value being passed on as
The type error here is because My assumption is that we're running into an issue between how we want to represent it in Figma and how it's structured over in TS world 👀 Let me know how you would like to resolve these. My fear for disabling TypeScript on these examples is that TS seems to be catching snippets that would be invalid if someone tried to copy and use them in code due to the type mismatches. |
This PR adds some more code connect files to connect react components to figma implementations.
Rollout strategy
Testing & Reviewing
Merge checklist