-
Notifications
You must be signed in to change notification settings - Fork 638
feat(Radio): remove support for sx #6833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 16e1e86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes sx
prop support from the Radio component as part of a larger effort to modernize the component API. The change simplifies the component by eliminating the styled-system integration and replacing the BoxWithFallback
wrapper with a native input
element.
Key Changes:
- Remove
SxProp
from theRadioProps
type definition - Replace
BoxWithFallback
wrapper with nativeinput
element - Update component documentation to reflect the removed
sx
prop
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/react/src/Radio/Radio.tsx | Remove SxProp import and type, replace BoxWithFallback with native input element |
packages/react/src/Radio/Radio.docs.json | Remove sx prop from component documentation |
.changeset/fair-views-laugh.md | Add changeset entry documenting the breaking change |
"name": "as", | ||
"type": "React.ElementType", | ||
"defaultValue": "\"input\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The as
prop is still documented but the component now uses a native input
element directly instead of BoxWithFallback
. This prop should likely be removed from the documentation as it may no longer be functional.
Copilot uses AI. Check for mistakes.
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/2619 |
🟢 ci completed with status |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
Closes #6772
Changelog
New
Changed
Removed
sx
from RadioRollout strategy
This component does not have
sx
usage ingithub-ui
and other usage is minimal and can be migrated, I think. As a result, we can merge this if github-ui / ci is ✅