Skip to content

Conversation

joshblack
Copy link
Member

Closes #6772

Changelog

New

Changed

Removed

  • Remove support for sx from Radio

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

This component does not have sx usage in github-ui and other usage is minimal and can be migrated, I think. As a result, we can merge this if github-ui / ci is ✅

@joshblack joshblack requested a review from a team as a code owner September 10, 2025 21:38
@joshblack joshblack requested review from Copilot and TylerJDev and removed request for Copilot September 10, 2025 21:38
Copy link

changeset-bot bot commented Sep 10, 2025

🦋 Changeset detected

Latest commit: 16e1e86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 10, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 10, 2025
Copy link
Contributor

github-actions bot commented Sep 10, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.52 KB (+0.04% 🔺)
packages/react/dist/browser.umd.js 89.68 KB (+0.1% 🔺)

@Copilot Copilot AI review requested due to automatic review settings September 10, 2025 22:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes sx prop support from the Radio component as part of a larger effort to modernize the component API. The change simplifies the component by eliminating the styled-system integration and replacing the BoxWithFallback wrapper with a native input element.

Key Changes:

  • Remove SxProp from the RadioProps type definition
  • Replace BoxWithFallback wrapper with native input element
  • Update component documentation to reflect the removed sx prop

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/Radio/Radio.tsx Remove SxProp import and type, replace BoxWithFallback with native input element
packages/react/src/Radio/Radio.docs.json Remove sx prop from component documentation
.changeset/fair-views-laugh.md Add changeset entry documenting the breaking change

Comment on lines 64 to 66
"name": "as",
"type": "React.ElementType",
"defaultValue": "\"input\""
Copy link
Preview

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The as prop is still documented but the component now uses a native input element directly instead of BoxWithFallback. This prop should likely be removed from the documentation as it may no longer be functional.

Copilot uses AI. Check for mistakes.

@github-actions github-actions bot temporarily deployed to storybook-preview-6833 September 11, 2025 16:42 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 12, 2025
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/2619

@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Sep 16, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 22, 2025
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@francinelucca francinelucca added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit 5ad1e93 Sep 22, 2025
42 checks passed
@francinelucca francinelucca deleted the feat/remove-sx-from-radio branch September 22, 2025 19:05
@primer primer bot mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for sx from the Radio component
3 participants