-
Notifications
You must be signed in to change notification settings - Fork 638
Fix PageHeader type issues #6896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 87a4898 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3046 |
🟢 ci completed with status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes TypeScript type issues in the PageHeader component that were causing integration test failures. The primary issue was missing subcomponent exports and incorrect type definitions in the styled-react package.
- Exports missing PageHeader subcomponents (TitleArea, ContextArea, etc.) from styled-react
- Adds PropsWithChildren wrapper to PageHeaderTitleProps and creates PageHeaderTitleAreaProps
- Exports the new TitleAreaProps type and ChildrenPropTypes from the main react package
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/styled-react/src/components/PageHeader.tsx | Adds missing subcomponent exports and fixes type definitions with PropsWithChildren |
packages/react/src/index.ts | Exports new PageHeaderTitleAreaProps and PageHeaderChildrenPropTypes types |
packages/react/src/tests/snapshots/exports.test.ts.snap | Updates test snapshot to reflect new exported types |
packages/react/src/PageHeader/PageHeader.tsx | Exports TitleAreaProps type that was previously internal |
.changeset/nasty-seals-carry.md | Documents the patch-level changes for both packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Thanks for fixing this!!
The PageHeader change PR is causing integration test failing.
Error message:
The issue is that sub components like
TitleArea
,ContextArea
, andContextAreaActions
are not exported fromstyled-react
, and some of the Props are not wrapped byPropsWithChildren