-
Notifications
You must be signed in to change notification settings - Fork 638
Adjust text-decoration-offset for Link component #6927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 500e393 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Uh oh! @lukasoppermann, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:
Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adjusts the underline positioning for the Link component by adding a text-underline-offset
property to bring the underline closer to the text. The change reduces the distance between text and its decorative underline for improved visual appearance.
Key Changes:
- Added
text-underline-offset: 0.1rem
to the Link component's CSS module - Included changeset documentation for a patch release
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/react/src/Link/Link.module.css | Adds text-underline-offset property to reduce underline distance |
.changeset/tender-dodos-create.md | Documents the change for patch release versioning |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Closes # https://github.com/github/primer/issues/5933#issuecomment-3352390446
Changelog
This reduced the distance of the link underline.
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist