-
Notifications
You must be signed in to change notification settings - Fork 638
forward Underline.Tab, Underline.Panels from @primer/react #6931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 15824db.
🦋 Changeset detectedLatest commit: 2c7b3b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
…/react into fix/revert-underlinepanels-change
…/react into fix/revert-underlinepanels-change
…/react into fix/revert-underlinepanels-change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the UnderlinePanels component in the styled-react package to forward subcomponents directly from @primer/react instead of wrapping them with styled-components. The change addresses issues with wrapped subcomponents not working well due to child type comparison logic.
- Removes wrapped Tab and Panel components from styled-react and forwards them directly from @primer/react
- Updates @primer/react UnderlinePanels to use direct component type comparison instead of displayName checks
- Removes sx prop support from subcomponents as it's not currently used
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
packages/styled-react/src/experimental.tsx | Minor reordering of export statements |
packages/styled-react/src/components/UnderlinePanels.tsx | Removes wrapped subcomponents and forwards directly from @primer/react |
packages/styled-react/src/tests/primer-react-experimental.browser.test.tsx | Removes test for sx prop support on UnderlinePanels.Panel |
packages/react/src/experimental/UnderlinePanels/UnderlinePanels.tsx | Updates child type comparison logic to use direct component references |
.changeset/rude-windows-bathe.md | Adds changelog entry for the changes |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3610 |
seeing the reported failure on other branches, unrelated to these changes |
🔴 ci completed with status |
wrapped subcomponents wont work well for UnderlinePanels due to the child type comparison, modifying to forward the original UnderlinePanels.Tab and UnderlinePanels.Panel from @primer/react.
There's no need to support sx in these subcomponents since we currently have no usage of it so this solution works fine (see https://primer-query.githubapp.com/?query=name%3A%22UnderlinePanels.Tab%22+attribute%3A%22sx%22, https://primer-query.githubapp.com/?query=name%3A%22UnderlinePanels.Panel%22+attribute%3A%22sx%22)
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist