Skip to content

Conversation

langermank
Copy link
Contributor

Closes https://github.com/github/primer/issues/4257

before after
Old title Updated title

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@langermank langermank requested a review from a team as a code owner October 6, 2025 20:28
Copy link

changeset-bot bot commented Oct 6, 2025

🦋 Changeset detected

Latest commit: 68cf909

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Patch
@primer/styled-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ConfirmationDialog component's heading styling by replacing the custom-styled <h1> element with the design system's Heading component to ensure consistent typography across the application.

Key changes:

  • Import and use the Heading component instead of plain <h1>
  • Remove custom CSS styles for the heading element
  • Apply "small" variant to the Heading component for consistent sizing

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/ConfirmationDialog/ConfirmationDialog.tsx Replaces custom <h1> with Heading component using "small" variant
packages/react/src/ConfirmationDialog/ConfirmationDialog.module.css Removes custom font-size, font-weight, and margin styles for h1 element

padding: var(--base-size-8);
flex-direction: row;

> h1 {
Copy link
Preview

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS selector > h1 may not match the new Heading component structure. Consider updating the selector to target the actual rendered element or use a more generic approach to ensure the padding and flex-grow styles are properly applied.

Suggested change
> h1 {
> * {

Copilot uses AI. Check for mistakes.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 6, 2025
Copy link
Contributor

github-actions bot commented Oct 6, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-6954 October 6, 2025 20:32 Abandoned
@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 6, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6954 October 6, 2025 20:40 Inactive
@primer primer bot requested a review from a team as a code owner October 6, 2025 20:48
@primer primer bot requested a review from mperrotti October 6, 2025 20:48
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 6, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6954 October 6, 2025 20:57 Inactive
@langermank langermank added this pull request to the merge queue Oct 6, 2025
Merged via the queue into main with commit 7dd483f Oct 6, 2025
42 checks passed
@langermank langermank deleted the confirmation-dialog-heading branch October 6, 2025 21:52
@primer primer bot mentioned this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants