-
Notifications
You must be signed in to change notification settings - Fork 638
Adjust ConfirmationDialog heading styling #6954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 68cf909 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the ConfirmationDialog component's heading styling by replacing the custom-styled <h1>
element with the design system's Heading
component to ensure consistent typography across the application.
Key changes:
- Import and use the
Heading
component instead of plain<h1>
- Remove custom CSS styles for the heading element
- Apply "small" variant to the
Heading
component for consistent sizing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/react/src/ConfirmationDialog/ConfirmationDialog.tsx | Replaces custom <h1> with Heading component using "small" variant |
packages/react/src/ConfirmationDialog/ConfirmationDialog.module.css | Removes custom font-size, font-weight, and margin styles for h1 element |
padding: var(--base-size-8); | ||
flex-direction: row; | ||
|
||
> h1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSS selector > h1
may not match the new Heading
component structure. Consider updating the selector to target the actual rendered element or use a more generic approach to ensure the padding and flex-grow styles are properly applied.
> h1 { | |
> * { |
Copilot uses AI. Check for mistakes.
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
Closes https://github.com/github/primer/issues/4257
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist