Ethan.carlsson/dev 4690 - Update authorization with OAuth in SDK #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires consumers to do more, but much lower chance of bugs
I think this is uglier but, and I like my first approach of doing it automatically. But this is more explicit and uses the same structure as the storeKey approach. Also added a new test and exception in the constructor
Pawel knows his stuff
Old store key will be phased out
…ls are not set Also skip some tests if credentials not set. I don't like this, but it's the best way to handle it for now
pawel-polanski-printful
suggested changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update authorization with OAuth in SDK