-
Notifications
You must be signed in to change notification settings - Fork 850
Fix default --output value for prisma init #7113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDocumentation update: in the Prisma CLI reference, the init command’s Options table changes the default Prisma Client --output path from node_modules/.prisma/client to ../generated/prisma. No code or control-flow changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
content/200-orm/500-reference/200-prisma-cli-reference.mdx (2)
138-138
: Default path update looks correct; consider a short clarifier.Changing the init default for
--output
to../generated/prisma
aligns with current guidance to use a custom output and the ongoing shift away from generating intonode_modules
by default. A brief note that this default applies to the schema created byprisma init
(whileprisma generate
still defaults tonode_modules/.prisma/client
unless an output is set) would prevent confusion. (prisma.io, prismagraphql.com)If possible, please confirm with a quick local check on Prisma CLI 6.15.0: run
npx prisma@6.15.0 init
in a temp folder and verify the generatedschema.prisma
includesoutput = "../generated/prisma"
. The 6.15.0 release comms also reinforce the “custom output” direction. (prisma.io, github.com)
329-332
: Keep init examples consistent: addoutput
here too.The “init --url” Generated Assets schema omits the
output
line, which contradicts the new default shown earlier and in.gitignore
. Suggest adding it for consistency:generator client { provider = "prisma-client-js" + output = "../generated/prisma" }
Please confirm that
prisma init --url ...
also emits theoutput
field today; if not, we should add a short note explaining why this variant differs. (prisma.io)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/200-orm/500-reference/200-prisma-cli-reference.mdx
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Check internal links
- GitHub Check: runner / linkspector
With
6.15.0
cli when I runnpx prisma init
it generates output with different default than documented.Summary by CodeRabbit