Skip to content
This repository has been archived by the owner on Jan 14, 2021. It is now read-only.

Photon filters in prop missing null support #242

Closed
MichalLytek opened this issue Oct 3, 2019 · 1 comment
Closed

Photon filters in prop missing null support #242

MichalLytek opened this issue Oct 3, 2019 · 1 comment
Assignees
@timsuchanek
Labels
bug/2-confirmed We have confirmed that this is a bug. kind/bug A reported bug.
Milestone
Preview 14

Comments

@MichalLytek
Copy link

The Photon find filters like StringFilter have all properties optional with null support but the in and notIn have only Enumerable<string> optional type:

image

This conflict with generated GraphQL types based on DMMF schema:

image

This apply to all Enumerable usage in Photon generated types:

image

It's a really big blocking problem for the integration of Prisma2 and GraphQL when we want to pass the nullable args to the photon query.
@schickling schickling added the process/candidate Candidate for next Milestone. label Oct 3, 2019
@timsuchanek timsuchanek self-assigned this Oct 4, 2019
@timsuchanek
Copy link
Contributor

Fixed in latest alpha.

@janpio janpio added this to the Preview 14 milestone Oct 7, 2019
@janpio janpio added bug/2-confirmed We have confirmed that this is a bug. kind/bug A reported bug. and removed process/candidate Candidate for next Milestone. labels Oct 7, 2019
@jhanschoo jhanschoo mentioned this issue Jun 24, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timsuchanek timsuchanek

Labels
bug/2-confirmed We have confirmed that this is a bug. kind/bug A reported bug.
Projects
None yet
Milestone
Preview 14
Development

No branches or pull requests
4 participants
@janpio @timsuchanek @schickling @MichalLytek