Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update mysql docker tag to v5.6.51 #2734

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 2, 2022

Mend Renovate

This PR contains the following updates:

Package Update Change
mysql patch 5.6.50 -> 5.6.51

Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot changed the title chore(deps): update dependency mysql to v5.6.51 Update dependency mysql to v5.6.51 Mar 12, 2022
@renovate renovate bot changed the title Update dependency mysql to v5.6.51 chore(deps): update dependency mysql to v5.6.51 Apr 21, 2022
@renovate renovate bot changed the title chore(deps): update dependency mysql to v5.6.51 Update dependency mysql to v5.6.51 Apr 21, 2022
@CLAassistant
Copy link

CLAassistant commented Jun 18, 2022

CLA assistant check
All committers have signed the CLA.

@renovate renovate bot changed the title Update dependency mysql to v5.6.51 Update mysql Docker tag to v5.6.51 Aug 10, 2022
@renovate renovate bot changed the title Update mysql Docker tag to v5.6.51 Update mysql Docker tag to v5.6.51 - autoclosed Aug 31, 2022
@renovate renovate bot closed this Aug 31, 2022
@renovate renovate bot deleted the renovate/mysql-5.6.x branch August 31, 2022 12:11
@renovate renovate bot changed the title Update mysql Docker tag to v5.6.51 - autoclosed Update mysql Docker tag to v5.6.51 Aug 31, 2022
@renovate renovate bot reopened this Aug 31, 2022
@renovate renovate bot restored the renovate/mysql-5.6.x branch August 31, 2022 16:32
@renovate renovate bot changed the title Update mysql Docker tag to v5.6.51 chore(deps): update mysql docker tag to v5.6.51 Sep 27, 2022
@renovate renovate bot changed the title chore(deps): update mysql docker tag to v5.6.51 chore(deps): update mysql docker tag to v5.6.51 - autoclosed Oct 27, 2022
@renovate renovate bot closed this Oct 27, 2022
@renovate renovate bot deleted the renovate/mysql-5.6.x branch October 27, 2022 23:59
@renovate renovate bot changed the title chore(deps): update mysql docker tag to v5.6.51 - autoclosed chore(deps): update mysql docker tag to v5.6.51 Oct 28, 2022
@renovate renovate bot reopened this Oct 28, 2022
@renovate renovate bot restored the renovate/mysql-5.6.x branch October 28, 2022 02:27
@renovate renovate bot changed the title chore(deps): update mysql docker tag to v5.6.51 Update mysql Docker tag to v5.6.51 Dec 17, 2022
@renovate renovate bot changed the title Update mysql Docker tag to v5.6.51 chore(deps): update mysql docker tag to v5.6.51 Dec 17, 2022
@renovate renovate bot force-pushed the renovate/mysql-5.6.x branch 3 times, most recently from 435fb75 to 8df2167 Compare March 14, 2023 10:01
@janpio janpio requested a review from a team as a code owner June 14, 2023 10:52
@Jolg42
Copy link
Contributor

Jolg42 commented Jun 30, 2023

Screenshot 2023-06-30 at 16 01 20

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 30, 2023

CodSpeed Performance Report

Merging #2734 will not alter performance

Comparing renovate/mysql-5.6.x (32547a6) with main (af6ceee)

Summary

✅ 11 untouched benchmarks

@Jolg42
Copy link
Contributor

Jolg42 commented Jun 30, 2023

Currently fails with https://github.com/prisma/prisma-engines/actions/runs/5423728790/jobs/9862528177?pr=2734#step:6:502

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/introspection_tests.rs (target/debug/deps/introspection_tests-e0bf269aa9cea468)

running 564 tests
Error creating a database connection.
error: test failed, to rerun pass `-p sql-introspection-tests --test introspection_tests`

Caused by:
  process didn't exit successfully: `/home/runner/work/prisma-engines/prisma-engines/target/debug/deps/introspection_tests-e0bf269aa9cea468` (exit status: 1)

@renovate renovate bot requested a review from a team as a code owner December 7, 2023 13:51
@renovate renovate bot requested review from jkomyno and Druue and removed request for a team December 7, 2023 13:51
@Jolg42
Copy link
Contributor

Jolg42 commented Dec 7, 2023

There is also

time="2023-12-07T13:51:23Z" level=warning msg="The \"INIT_WAIT_SEC\" variable is not set. Defaulting to a blank string."

Copy link
Contributor

github-actions bot commented Jan 13, 2024

WASM Size

Engine This PR Base branch Diff
Postgres 2.062MiB 2.062MiB 0.000B
Postgres (gzip) 814.262KiB 814.262KiB 0.000B
Mysql 2.044MiB 2.044MiB 0.000B
Mysql (gzip) 806.135KiB 806.135KiB 0.000B
Sqlite 2.005MiB 2.005MiB 0.000B
Sqlite (gzip) 792.510KiB 792.512KiB -2.000B

Copy link
Contributor

github-actions bot commented Jan 13, 2024

✅ WASM query-engine performance won't change substantially (1.007x)

Full benchmark report
DATABASE_URL="postgresql://postgres:postgres@localhost:5432/bench?schema=imdb_bench&sslmode=disable" \
node --experimental-wasm-modules query-engine/driver-adapters/executor/dist/bench.mjs
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
cpu: AMD EPYC 7763 64-Core Processor
runtime: node v18.19.1 (x64-linux)

benchmark                   time (avg)             (min … max)       p75       p99      p999
-------------------------------------------------------------- -----------------------------
• movies.findMany() (all - ~50K)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     364 ms/iter       (362 ms … 370 ms)    368 ms    370 ms    370 ms
Web Assembly: Latest       451 ms/iter       (449 ms … 455 ms)    454 ms    455 ms    455 ms
Web Assembly: Current      461 ms/iter       (457 ms … 478 ms)    464 ms    478 ms    478 ms
Node API: Current          197 ms/iter       (195 ms … 198 ms)    198 ms    198 ms    198 ms

summary for movies.findMany() (all - ~50K)
  Web Assembly: Current
   2.34x slower than Node API: Current
   1.27x slower than Web Assembly: Baseline
   1.02x slower than Web Assembly: Latest

• movies.findMany({ take: 2000 })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  14'821 µs/iter (14'655 µs … 15'414 µs) 14'836 µs 15'414 µs 15'414 µs
Web Assembly: Latest    18'229 µs/iter (17'985 µs … 20'610 µs) 18'163 µs 20'610 µs 20'610 µs
Web Assembly: Current   18'628 µs/iter (18'189 µs … 20'055 µs) 18'813 µs 20'055 µs 20'055 µs
Node API: Current        8'078 µs/iter   (7'914 µs … 8'408 µs)  8'113 µs  8'408 µs  8'408 µs

summary for movies.findMany({ take: 2000 })
  Web Assembly: Current
   2.31x slower than Node API: Current
   1.26x slower than Web Assembly: Baseline
   1.02x slower than Web Assembly: Latest

• movies.findMany({ where: {...}, take: 2000 })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   2'317 µs/iter   (2'210 µs … 3'380 µs)  2'304 µs  3'319 µs  3'380 µs
Web Assembly: Latest     2'828 µs/iter   (2'724 µs … 3'788 µs)  2'812 µs  3'551 µs  3'788 µs
Web Assembly: Current    2'928 µs/iter   (2'738 µs … 5'221 µs)  2'858 µs  4'889 µs  5'221 µs
Node API: Current        1'359 µs/iter   (1'292 µs … 1'594 µs)  1'381 µs  1'568 µs  1'594 µs

summary for movies.findMany({ where: {...}, take: 2000 })
  Web Assembly: Current
   2.16x slower than Node API: Current
   1.26x slower than Web Assembly: Baseline
   1.04x slower than Web Assembly: Latest

• movies.findMany({ include: { cast: true } take: 2000 }) (m2m)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     575 ms/iter       (569 ms … 590 ms)    579 ms    590 ms    590 ms
Web Assembly: Latest       759 ms/iter       (751 ms … 774 ms)    767 ms    774 ms    774 ms
Web Assembly: Current      750 ms/iter       (743 ms … 766 ms)    753 ms    766 ms    766 ms
Node API: Current          462 ms/iter       (454 ms … 480 ms)    465 ms    480 ms    480 ms

summary for movies.findMany({ include: { cast: true } take: 2000 }) (m2m)
  Web Assembly: Current
   1.62x slower than Node API: Current
   1.3x slower than Web Assembly: Baseline
   1.01x faster than Web Assembly: Latest

• movies.findMany({ where: {...}, include: { cast: true } take: 2000 }) (m2m)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  79'394 µs/iter (79'129 µs … 79'757 µs) 79'710 µs 79'757 µs 79'757 µs
Web Assembly: Latest       106 ms/iter       (106 ms … 107 ms)    106 ms    107 ms    107 ms
Web Assembly: Current      105 ms/iter       (104 ms … 105 ms)    105 ms    105 ms    105 ms
Node API: Current       59'659 µs/iter (59'268 µs … 60'002 µs) 59'912 µs 60'002 µs 60'002 µs

summary for movies.findMany({ where: {...}, include: { cast: true } take: 2000 }) (m2m)
  Web Assembly: Current
   1.76x slower than Node API: Current
   1.32x slower than Web Assembly: Baseline
   1.01x faster than Web Assembly: Latest

• movies.findMany({ take: 2000, include: { cast: { include: { person: true } } } })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   1'011 ms/iter   (1'006 ms … 1'026 ms)  1'015 ms  1'026 ms  1'026 ms
Web Assembly: Latest     1'259 ms/iter   (1'248 ms … 1'278 ms)  1'271 ms  1'278 ms  1'278 ms
Web Assembly: Current    1'241 ms/iter   (1'234 ms … 1'268 ms)  1'242 ms  1'268 ms  1'268 ms
Node API: Current          873 ms/iter       (851 ms … 894 ms)    887 ms    894 ms    894 ms

summary for movies.findMany({ take: 2000, include: { cast: { include: { person: true } } } })
  Web Assembly: Current
   1.42x slower than Node API: Current
   1.23x slower than Web Assembly: Baseline
   1.01x faster than Web Assembly: Latest

• movie.findMany({ where: { ... }, take: 2000, include: { cast: { include: { person: true } } } })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     142 ms/iter       (141 ms … 142 ms)    142 ms    142 ms    142 ms
Web Assembly: Latest       176 ms/iter       (174 ms … 181 ms)    177 ms    181 ms    181 ms
Web Assembly: Current      173 ms/iter       (172 ms … 176 ms)    174 ms    176 ms    176 ms
Node API: Current          102 ms/iter       (101 ms … 105 ms)    103 ms    105 ms    105 ms

summary for movie.findMany({ where: { ... }, take: 2000, include: { cast: { include: { person: true } } } })
  Web Assembly: Current
   1.69x slower than Node API: Current
   1.22x slower than Web Assembly: Baseline
   1.01x faster than Web Assembly: Latest

• movie.findMany({ where: { reviews: { author: { ... } }, take: 100 }) (to-many -> to-one)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   1'079 µs/iter     (976 µs … 1'965 µs)  1'040 µs  1'947 µs  1'965 µs
Web Assembly: Latest     1'341 µs/iter   (1'280 µs … 1'962 µs)  1'341 µs  1'819 µs  1'962 µs
Web Assembly: Current    1'370 µs/iter   (1'301 µs … 2'048 µs)  1'367 µs  1'850 µs  2'048 µs
Node API: Current          770 µs/iter     (700 µs … 1'179 µs)    792 µs    936 µs  1'179 µs

summary for movie.findMany({ where: { reviews: { author: { ... } }, take: 100 }) (to-many -> to-one)
  Web Assembly: Current
   1.78x slower than Node API: Current
   1.27x slower than Web Assembly: Baseline
   1.02x slower than Web Assembly: Latest

• movie.findMany({ where: { cast: { person: { ... } }, take: 100 }) (m2m -> to-one)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   1'053 µs/iter   (1'004 µs … 1'721 µs)  1'050 µs  1'613 µs  1'721 µs
Web Assembly: Latest     1'334 µs/iter   (1'281 µs … 1'968 µs)  1'341 µs  1'665 µs  1'968 µs
Web Assembly: Current    1'351 µs/iter   (1'299 µs … 1'776 µs)  1'360 µs  1'676 µs  1'776 µs
Node API: Current          801 µs/iter     (705 µs … 1'823 µs)    810 µs  1'263 µs  1'823 µs

summary for movie.findMany({ where: { cast: { person: { ... } }, take: 100 }) (m2m -> to-one)
  Web Assembly: Current
   1.69x slower than Node API: Current
   1.28x slower than Web Assembly: Baseline
   1.01x slower than Web Assembly: Latest

After changes in 32547a6

@Jolg42 Jolg42 closed this Apr 3, 2024
@Jolg42 Jolg42 deleted the renovate/mysql-5.6.x branch April 3, 2024 07:04
Copy link
Contributor Author

renovate bot commented Apr 3, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (5.6.51). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech/engines Issue for tech Engines. topic: tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants