update react dependencies to inclued 17 as npm 7 won't install without #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you so much for submitting a PR! This was a known issue indeed, prismicio/prismic-cli#77 |
|
Sorry that I missed that other issue. I can confirm that both libraries work with react 17. Let me know if you want me to update the pr or anything else. |
lihbr
added a commit
that referenced
this pull request
Feb 17, 2021
|
Hey @rphuber I'm sorry I didn't manage to use your PR but we truly appreciate you submitting one! Next SliceZone has been updated to allow correct peer dependencies :) https://www.npmjs.com/package/next-slicezone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Update to
reactandreact-domdependencies to include v17 as npm 7 will not install the slice-machine properly without them.Description
As I was working through the getting started I was having trouble getting the
prismic sm --setupcommand to work. I was getting errors about react dependencies and it would fail the install of them. I was using npm v7 and it looks like it handles dependencies in a much more strict manner. When I downgraded to npm v6 it worked with just warnings about the dependency issues. This should fix that issue for this library. I will put in another pr for theessential-slicespackage.update
package.jsonto include v17 of reactwill fix install problem with npm v7