-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signup-and-vote, process messages in reverse order, and enable zkutils #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuhcc
reviewed
Sep 29, 2020
Closed
Includes PR #181 which enables zkutil, so there is no longer a need to download the large ptau file. |
… reverse processing
weijiekoh
changed the title
Signup-and-vote, and process messages in reverse order (wip)
Signup-and-vote, process messages in reverse order, and enable zkutils
Oct 1, 2020
xuhcc
reviewed
Oct 1, 2020
…essedMessages to a public bool
xuhcc
reviewed
Oct 1, 2020
xuhcc
reviewed
Oct 1, 2020
Co-authored-by: Kirill Goncharov <kdgoncharov@gmail.com>
Throw error when zkutil is not installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #170. This PR removes the signup period. Now anyone can sign up and publish messages before the voting period ends. To prevent an attack where a briber makes someone sign up and change their key immediately, this PR also reverses the order of message processing.
It also includes #181, which uses zkutil instead of snarkjs for the trusted setup (for testing only) and proof generation.