Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup-and-vote, process messages in reverse order, and enable zkutils #180

Merged
merged 23 commits into from
Oct 2, 2020

Conversation

weijiekoh
Copy link
Contributor

@weijiekoh weijiekoh commented Sep 29, 2020

Addresses #170. This PR removes the signup period. Now anyone can sign up and publish messages before the voting period ends. To prevent an attack where a briber makes someone sign up and change their key immediately, this PR also reverses the order of message processing.

It also includes #181, which uses zkutil instead of snarkjs for the trusted setup (for testing only) and proof generation.

contracts/sol/MACI.sol Outdated Show resolved Hide resolved
@weijiekoh weijiekoh mentioned this pull request Oct 1, 2020
@weijiekoh
Copy link
Contributor Author

Includes PR #181 which enables zkutil, so there is no longer a need to download the large ptau file.

@weijiekoh weijiekoh self-assigned this Oct 1, 2020
@weijiekoh weijiekoh added the enhancement New feature or request label Oct 1, 2020
@weijiekoh weijiekoh linked an issue Oct 1, 2020 that may be closed by this pull request
@weijiekoh weijiekoh changed the title Signup-and-vote, and process messages in reverse order (wip) Signup-and-vote, process messages in reverse order, and enable zkutils Oct 1, 2020
@weijiekoh weijiekoh marked this pull request as ready for review October 1, 2020 13:36
contracts/sol/MACI.sol Outdated Show resolved Hide resolved
circuits/scripts/installZkutil.sh Show resolved Hide resolved
contracts/sol/MACI.sol Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
weijiekoh and others added 3 commits October 1, 2020 22:57
Co-authored-by: Kirill Goncharov <kdgoncharov@gmail.com>
Throw error when zkutil is not installed
@weijiekoh weijiekoh merged commit 0565ad9 into master Oct 2, 2020
@corydickson corydickson deleted the feat/signup-and-vote branch June 7, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] sign up and vote
2 participants