Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect packageManager field in package.json #8

Merged
merged 5 commits into from
Jul 7, 2022
Merged

feat: detect packageManager field in package.json #8

merged 5 commits into from
Jul 7, 2022

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Jul 6, 2022

prepare for pkg-size/action#49

lib/ci.js Outdated Show resolved Hide resolved
lib/ci.js Outdated Show resolved Hide resolved
@JounQin
Copy link
Contributor Author

JounQin commented Jul 7, 2022

@privatenumber Can you fix the CI error first and then I can do a rebase?

https://github.com/privatenumber/ci/runs/7227941544?check_suite_focus=true

package.json Outdated Show resolved Hide resolved
@privatenumber
Copy link
Owner

Thanks for handling the merge upstream, was going to do that today

@privatenumber privatenumber changed the title feat: detect packageManager field in package.json automatically feat: detect packageManager field in package.json Jul 7, 2022
@privatenumber privatenumber linked an issue Jul 7, 2022 that may be closed by this pull request
@privatenumber privatenumber merged commit a629271 into privatenumber:develop Jul 7, 2022
@JounQin JounQin deleted the feat/packageManager branch July 7, 2022 22:52
@JounQin
Copy link
Contributor Author

JounQin commented Jul 9, 2022

When will this be released?

@privatenumber
Copy link
Owner

Working on adding tests before the release because its a big change but pretty booked out for the weekend. Likely Monday. Thanks for your patience 🙏

@JounQin
Copy link
Contributor Author

JounQin commented Jul 9, 2022

Thanks for the promising schedule!

@privatenumber
Copy link
Owner

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: read from packageManager
2 participants