Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display of linked target field content #211

Merged
merged 9 commits into from
Jul 25, 2022

Conversation

prjemian
Copy link
Owner

@prjemian prjemian added the bug label Jul 24, 2022
@prjemian prjemian added this to the v1.0.0-release milestone Jul 24, 2022
@prjemian prjemian self-assigned this Jul 24, 2022
@coveralls
Copy link

coveralls commented Jul 24, 2022

Coverage Status

Coverage increased (+0.4%) to 95.544% when pulling 3ad67b1 on 210-display-of-target-field-content into a079c2f on main.

@prjemian
Copy link
Owner Author

@carterbox Ready for review.

@prjemian prjemian requested a review from carterbox July 25, 2022 02:57
@lgtm-com
Copy link

lgtm-com bot commented Jul 25, 2022

This pull request introduces 1 alert when merging c47f252 into a079c2f - view on LGTM.com

new alerts:

  • 1 for Unused import

punx/h5tree.py Outdated Show resolved Hide resolved
punx/h5tree.py Outdated Show resolved Hide resolved
punx/h5tree.py Show resolved Hide resolved
punx/h5tree.py Show resolved Hide resolved
punx/tests/test_issue210.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Jul 25, 2022

This pull request fixes 2 alerts when merging 3ad67b1 into a079c2f - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@prjemian
Copy link
Owner Author

@carterbox Ready again.

@prjemian prjemian requested a review from carterbox July 25, 2022 19:51
]
__install_requires__ = """
h5py
hdf5plugin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically not required, but as developer you can add to mandatory dependencies.

@prjemian
Copy link
Owner Author

@carterbox Thanks for the reviews!

@prjemian prjemian merged commit 2910677 into main Jul 25, 2022
@prjemian prjemian deleted the 210-display-of-target-field-content branch July 25, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

only link shown for data field
3 participants