Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add reports from hklpy #254

Merged
merged 7 commits into from
Feb 25, 2022
Merged

add reports from hklpy #254

merged 7 commits into from
Feb 25, 2022

Conversation

prjemian
Copy link
Owner

@prjemian prjemian added this to the 2021.2.0 milestone Feb 25, 2022
@prjemian prjemian self-assigned this Feb 25, 2022
@coveralls
Copy link

coveralls commented Feb 25, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 95.051% when pulling e845b7e on 227-add-hklpy-report into b75be47 on main.

@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2022

This pull request introduces 3 alerts when merging c7d37cb into b75be47 - view on LGTM.com

new alerts:

  • 2 for Unused local variable
  • 1 for Unnecessary pass

@prjemian
Copy link
Owner Author

No obvious need for the report() method in diffractometers.py. Perhaps to report about any data file contents.

@prjemian prjemian merged commit a53450e into main Feb 25, 2022
@prjemian prjemian deleted the 227-add-hklpy-report branch February 25, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@prjemian prjemian

Labels
enhancement
Projects
None yet
Milestone
2021.2.0
Development

Successfully merging this pull request may close these issues.

Add this report generated by the hklpy project
2 participants
@prjemian @coveralls