Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #221: Returning value if convert is None #222

Closed
wants to merge 1 commit into from
Closed

Fix #221: Returning value if convert is None #222

wants to merge 1 commit into from

Conversation

EmmaTinten
Copy link

@EmmaTinten EmmaTinten commented Mar 31, 2021

Fixes #221 .

Changes proposed in this pull request:

Returns the value if the converter is None.

Attention: @prkumar

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #222 (ada27cf) into master (d3ee283) will decrease coverage by 0.08%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
- Coverage   99.91%   99.83%   -0.09%     
==========================================
  Files          44       44              
  Lines        2398     2400       +2     
  Branches      182      183       +1     
==========================================
  Hits         2396     2396              
- Misses          2        3       +1     
- Partials        0        1       +1     
Impacted Files Coverage Δ
uplink/converters/keys.py 94.59% <33.33%> (-5.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3ee283...ada27cf. Read the comment docs.

@prkumar
Copy link
Owner

prkumar commented Jan 1, 2022

Fixed by #231

@prkumar prkumar closed this Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PartMap fails with converter=None
3 participants