Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @uplink.*Map to not throw error if converter is None #231

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

prkumar
Copy link
Owner

@prkumar prkumar commented Aug 2, 2021

Fixes #221

Attention: @prkumar

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #231 (6e24e55) into master (d3ee283) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          44       44           
  Lines        2398     2400    +2     
  Branches      182      183    +1     
=======================================
+ Hits         2396     2398    +2     
  Misses          2        2           
Impacted Files Coverage Δ
uplink/converters/keys.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3ee283...6e24e55. Read the comment docs.

@prkumar prkumar merged commit c0733e3 into master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PartMap fails with converter=None
1 participant