Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weak lensing #984

Merged
merged 89 commits into from
May 16, 2024
Merged

Weak lensing #984

merged 89 commits into from
May 16, 2024

Conversation

timwhite0
Copy link
Collaborator

@timwhite0 timwhite0 commented May 8, 2024

This PR adds inference capabilities for weak lensing shear and convergence.

It involves minimal changes to the BLISS infrastructure:

  • Adds shear and convergence as allowable params in TileCatalog.
  • Adds a bivariate normal variational dist for shear (which has two components).

The remaining additions are self-contained in case_studies/weak_lensing:

  • Lensing subclasses of ImageDecoder, CatalogPrior, VariationalDistSpec, and VariationalDist.
  • A new lensing metric (tile-level MSE for shear and convergence).
  • Several tutorial notebooks to demonstrate end-to-end functionality.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 92.17%. Comparing base (a8cbcb1) to head (aa92d30).

Files Patch % Lines
bliss/encoder/unconstrained_dists.py 33.33% 6 Missing ⚠️
bliss/catalog.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #984      +/-   ##
==========================================
- Coverage   92.38%   92.17%   -0.22%     
==========================================
  Files          23       23              
  Lines        2903     2914      +11     
==========================================
+ Hits         2682     2686       +4     
- Misses        221      228       +7     
Flag Coverage Δ
unittests 92.17% <41.66%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Tim White and others added 26 commits May 16, 2024 09:10
* use_checkerboard flag

* mode and sample metrics

* new prior elicitation case study

* new m2 prior: adds location parameter

* renaming truncated Pareto parameters

* mean sources = 0.9

* minor

* log val metrics under val

* todo notes

* black --diff pre-commit

* HST 15% off, not 22%?

* don't log trainer output on prediction

* fix m2 mean_sources rate; replace truncated Pareto with scipy implementation

* two point correlation metric sort of working

* minor

* minor

* tests passing; about to do 419GB training run

* updated dependent tiling case studies; corrected two point correlation metric

* reverting mean_sources...how did I get it so wrong?

* minor
…k with simple training loop for shear and convergence
timwhite0 and others added 22 commits May 16, 2024 09:11
…ce; add galaxy params back into variational dist sampling; revert to original architecture for now
…dated pyproject and lockfile to reflect change" to factor in prior refactoring of duplicate code.

This reverts commit e6fdd20.
Copy link
Contributor

@jeff-regier jeff-regier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeff-regier jeff-regier merged commit c543501 into master May 16, 2024
3 checks passed
@jeff-regier jeff-regier deleted the tw/weak_lensing branch May 16, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants