Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EKF-MLP #77

Merged
merged 7 commits into from
Jul 13, 2022
Merged

Implement EKF-MLP #77

merged 7 commits into from
Jul 13, 2022

Conversation

petergchang
Copy link
Collaborator

@petergchang petergchang commented Jul 12, 2022

Description

  • Reimplemented JSL Demo using SSM-JAX EKF code.
  • Reorganized portions of code and added comments explaining how EKF is used for readability.
  • Omitted saving figures for consistency with rest of the API.

Issue

#32

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@murphyk
Copy link
Member

murphyk commented Jul 13, 2022

This looks good. Some small requests:

  • I would prefer if each plot is its own figure, so we can save them separately, and then in latex, i can decide which ones to use. (Probably 10, 20, 30, and final=?? steps).
  • use same vertical scale for all plots (eg -30..30)
  • also create ekf_mlp.ipynb that imports this code, runs it, and shows the plots (cf https://github.com/probml/ssm-jax/blob/main/ssm_jax/lgssm/demos/kf_linreg.ipynb), so that i can point book readers to this colab.

@petergchang
Copy link
Collaborator Author

@murphyk
Thanks for your review, I submitted new commits that address your requests.
I can't import the demo module before the PR gets merged, so the Jupyter notebook does not work yet,
but it should work after the merge.

@murphyk murphyk merged commit 2e4e6c7 into probml:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants