Stale label removed after commenting on closed issue

[bkeepers]

I'm not sure if this should be expected behavior or not, but if an issue is closed from inactivity, and then someone comments on it, the label gets removed.

I wonder if it shouldn't attempt to change labels if the issue is closed.

[kotp]

I find the same issue. If the default, for example, is wonttix and someone asks something like "do we really want to not fix this only because it is stale?" the bot will remove that wontfix label. Someone else states that "Yes, we definitely won't fix this issue.", and then tries to re-label it as won't fix, the bot removes that label yet again.

This ends up being unproductive. This happens regardless of close/open status.

[kytrinyx]

I think if we used a label that never is used for any other purpose, then it would probably be fine to leave it. But since wontfix is the label that exists by default, it would be trickier to assume the presence of some custom label (and we would probably need special permissions to create the label if it was missing).

[kotp]

Perhaps a bot related default, that not only has the stale.yml file that must exist for the probot to run, but a check to see if something like pb_stale label is provided. It would provide the 'hook' I think for this, leaving "normal" labels free for use. Perhaps an additional flag that can be added, but not readded if it has some activity.

[bkeepers]

Thanks for the feedback. I'll prioritize working on this soon.

I think the easiest solution here is just to skip removing any labels once the issue is closed.

[kotp]

This also happens before the issue is closed... so it is a little bit more than that @bkeepers

[kotp]

Admittedly, we can search for any probot comments, but that removes the 'quick view' aspect of seeing the labels.

[kytrinyx]

@kotp If the issue is open and someone comments to say 'really? we're closing just because it's stale?' then the maintainer should probably respond and close the issue, in which case they can also add the stale label and it will be left on there.