[FEAT] Detect the Sequential Multi-instance Marker of an Activity #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
added
enhancement
csouchet
force-pushed
the
345-Detect_Sequential_Multi-instance_Marker_of_Activity
branch
from
777af6d
to
a4a9f4e
Compare
csouchet
force-pushed
the
345-Detect_Sequential_Multi-instance_Marker_of_Activity
branch
from
a4a9f4e
to
e34095a
Compare
tbouffard
requested changes
Aug 6, 2020
| it(`${bpmnKind} with Loop marker`, () => { | ||
| const shape = newShape(newShapeBpmnElement(bpmnKind, ShapeBpmnMarkerKind.LOOP), newLabel({ name: 'Arial' })); | ||
| expect(computeStyle(shape)).toEqual(`${bpmnKind};bpmn.markers=loop;fontFamily=Arial`); | ||
| describe.each([[ShapeBpmnMarkerKind.LOOP], [ShapeBpmnMarkerKind.MULTI_INSTANCE_SEQUENTIAL]])(`compute style - %s marker for ${bpmnKind}`, (markerKind: ShapeBpmnMarkerKind) => { |
There was a problem hiding this comment.
currently, it is run twice with the loop marker instead of once with the loop, once with the multi instance
Otherwise, we can put this specific test out of this block because we may not want to test expand marker + every other marker
There was a problem hiding this comment.
I was wrong the subprocess test is out of the describe block, my bad, sorry.
tbouffard
approved these changes
Aug 6, 2020
tbouffard
deleted the
345-Detect_Sequential_Multi-instance_Marker_of_Activity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #345
Expected
At commit 777af6d