Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Detect the Parallel Multi-instance Marker of an activity #469

Merged
merged 3 commits into from
Aug 6, 2020
Merged

[FEAT] Detect the Parallel Multi-instance Marker of an activity #469

merged 3 commits into from
Aug 6, 2020

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Aug 5, 2020 •
edited by tbouffard
Loading

Closes #346

Expected

image

At commit 4aaeed9

image

@csouchet csouchet added enhancement New feature or request depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first BPMN rendering Something about the way the lib is rendering BPMN elements BPMN support Something about the BPMN specification that the lib is already supporting or will support and removed BPMN rendering Something about the way the lib is rendering BPMN elements labels Aug 5, 2020
@csouchet csouchet force-pushed the 346-Detect_Parallel_Multi-instance_Marker_of_Activity branch from 4aaeed9 to 0d6db1b Compare August 6, 2020 09:40
@csouchet csouchet mentioned this pull request Aug 6, 2020
Merged
@csouchet csouchet force-pushed the 346-Detect_Parallel_Multi-instance_Marker_of_Activity branch from 0d6db1b to 91a14eb Compare August 6, 2020 11:02
@tbouffard tbouffard mentioned this pull request Aug 6, 2020
Merged
@tbouffard tbouffard added the rebase needed 💥 Pull request that must be rebased on the latest master commit prior being reviewed or merged label Aug 6, 2020
@tbouffard tbouffard force-pushed the 346-Detect_Parallel_Multi-instance_Marker_of_Activity branch from 91a14eb to 029f502 Compare August 6, 2020 14:11
@tbouffard tbouffard removed depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first rebase needed 💥 Pull request that must be rebased on the latest master commit prior being reviewed or merged labels Aug 6, 2020
tbouffard
tbouffard approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tbouffard tbouffard marked this pull request as ready for review August 6, 2020 14:16
@tbouffard tbouffard merged commit 702bb3e into master Aug 6, 2020
@tbouffard tbouffard deleted the 346-Detect_Parallel_Multi-instance_Marker_of_Activity branch August 6, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
BPMN support Something about the BPMN specification that the lib is already supporting or will support enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Detect the Parallel Multi-instance Marker of an activity
2 participants
@csouchet @tbouffard