-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed deleteProject handler #3046
Fixed deleteProject handler #3046
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good but I am extremely confused by why the Git diff is showing all the changes from the SASS PR. I think I can fix it for you (by merging the current branch into your branch) but not right now.
Thank you @lindapaiste for looking into it. I appreciate your effort to resolve the confusion. Please take your time, and let me know if you need any further assistance from my end. |
Thank you @lindapaiste for bringing this to my attention. It seems there might be a discrepancy in the Git diff, possibly showing changes from the SASS PR that aren't directly related to our current task, I think there could be mainly three reasons:
To address this, we may need to review the Git history and ensure that proper branch management practices are followed. There might be some unnecessary changes or merges that need to be cleaned up. Your help in resolving this issue is greatly appreciated. |
have a look on this @lindapaiste , Please take your time, and let me know if you need any further assistance from my end. |
Thanks for your work on this! Due to the amount of time that's passed I'm going to close this PR for now. I'm sorry that we couldn't get this in, but please feel free to reopen a new one or check out our other issues! |
Fixes #3023
Changes:
In this modification, I added a return statement before deleteObjectsFromS3 to ensure the function returns the Promise returned by deleteObjectsFromS3. Then, I modified the handleProjectDeletion function to wait for the delete operation to complete using .then() and .catch() blocks to handle any errors during the S3 deletion process.
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123