Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deleteProject handler #3046

Conversation

letscodedanish
Copy link
Contributor

@letscodedanish letscodedanish commented Feb 23, 2024

Fixes #3023

Changes:
In this modification, I added a return statement before deleteObjectsFromS3 to ensure the function returns the Promise returned by deleteObjectsFromS3. Then, I modified the handleProjectDeletion function to wait for the delete operation to complete using .then() and .catch() blocks to handle any errors during the S3 deletion process.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented Feb 23, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I am extremely confused by why the Git diff is showing all the changes from the SASS PR. I think I can fix it for you (by merging the current branch into your branch) but not right now.

@letscodedanish
Copy link
Contributor Author

letscodedanish commented Feb 23, 2024

This looks good but I am extremely confused by why the Git diff is showing all the changes from the SASS PR. I think I can fix it for you (by merging the current branch into your branch) but not right now.

Thank you @lindapaiste for looking into it. I appreciate your effort to resolve the confusion. Please take your time, and let me know if you need any further assistance from my end.

@letscodedanish
Copy link
Contributor Author

letscodedanish commented Feb 23, 2024

This looks good but I am extremely confused by why the Git diff is showing all the changes from the SASS PR. I think I can fix it for you (by merging the current branch into your branch) but not right now.

Thank you @lindapaiste for bringing this to my attention. It seems there might be a discrepancy in the Git diff, possibly showing changes from the SASS PR that aren't directly related to our current task, I think there could be mainly three reasons:

  1. It's possible that changes from other branches, such as the SASS PR, may be inadvertently included during the branch creation or merging process.
  2. The Git history might have become tangled or unclear, leading to unexpected changes being displayed in the diff.
  3. If multiple components or features are being developed concurrently in the repository, it's easier for changes to overlap or conflict in the diff view.

To address this, we may need to review the Git history and ensure that proper branch management practices are followed. There might be some unnecessary changes or merges that need to be cleaned up. Your help in resolving this issue is greatly appreciated.

@letscodedanish
Copy link
Contributor Author

This looks good but I am extremely confused by why the Git diff is showing all the changes from the SASS PR. I think I can fix it for you (by merging the current branch into your branch) but not right now.

have a look on this @lindapaiste , Please take your time, and let me know if you need any further assistance from my end.

@raclim
Copy link
Collaborator

raclim commented Jun 3, 2024

Thanks for your work on this! Due to the amount of time that's passed I'm going to close this PR for now. I'm sorry that we couldn't get this in, but please feel free to reopen a new one or check out our other issues!

@raclim raclim closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deleteProject handler doesn't wait for S3 deletion to complete
3 participants