Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imrove docs for p5.Image.filter() #4711

Closed
2 of 12 tasks
aferriss opened this issue Jul 24, 2020 · 6 comments
Closed
2 of 12 tasks

Imrove docs for p5.Image.filter() #4711

aferriss opened this issue Jul 24, 2020 · 6 comments

Comments

@aferriss
Copy link
Contributor

Most appropriate sub-area of p5.js?

  • Color
  • Core/Environment/Rendering
  • Data
  • Dom
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Documentation

Feature enhancement details:

I noticed that the docs page for filtering p5.Images is pretty scant on details of the individual filters with their parameters. It also suggests that users go looking for filters.js which seems like it could be tricky for beginners to locate. At least for me, the image.filter() page comes up first in the list on the reference search bar so unless you already know that there are two filter (three if you include sound) functions it could be hard to find.

I think it would be good to change it so that it is more in line with the main filter page. I feel like the docs on this page would be sufficient to move over to the image.filter() page along with some language about how that function only filters the image rather than the entire canvas.
Hopefully this would help newcomers find what they're looking for more easily.

@Rizz0S
Copy link
Contributor

Rizz0S commented Jul 29, 2020

I can take this if it's open!

@aferriss
Copy link
Contributor Author

@Rizz0S That'd be great, thank you!

@DhairyaBahl
Copy link

@aferriss I would like to work on this issue if its available ??

@lmccart
Copy link
Member

lmccart commented Mar 10, 2021

@DhairyaBahl would you still like to work on this?

@vsquareg
Copy link

This issue seems to be the duplicate of #5045 which has already been resolved by #5052.

@lmccart
Copy link
Member

lmccart commented Mar 17, 2021

thanks @vsquareg!

@lmccart lmccart closed this as completed Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants