Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for filter method is partly missing #5045

Closed
seldomU opened this issue Feb 14, 2021 · 4 comments · Fixed by #5052
Closed

Documentation for filter method is partly missing #5045

seldomU opened this issue Feb 14, 2021 · 4 comments · Fixed by #5052
Assignees

Comments

@seldomU
Copy link

seldomU commented Feb 14, 2021

Hello,

there are two filter methods, one for the canvas and one for images. The documentation for the canvas filter method has a description of the different filter types and what the filterParam means for each type. The image filter docs are missing this description, but reference it as "see above".

@rt1301
Copy link
Contributor

rt1301 commented Feb 16, 2021

@limzykenneth @montoyamoraga @seldomU Is this issue open? I would like to work on this if possible

@montoyamoraga
Copy link
Member

hi @seldomU thanks for pointing it out,
@rt1301 thanks for offering working on it, of course, i will go ahead and assign you

@rt1301
Copy link
Contributor

rt1301 commented Feb 18, 2021

@montoyamoraga Would it be better to transfer this issue to the p5.js-website repository? cause it looks like an issue regarding the website documentation.

@limzykenneth
Copy link
Member

The documentation for p5.js is written as inline comments and maintained along side the source code so this issue fits better here. You can have a read about how it works here.

montoyamoraga added a commit that referenced this issue Feb 21, 2021
Updated the p5.Image filter() method documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants