Handle MULTIPLY with alpha in WebGL #5855
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5854
Changes:
Note that 2D and WebGL MULTIPLY modes work differently now! The 2D mode has a bunch of quirks where it blends semi transparent colors with white and makes them opaque before multiplication. This PR chooses to handle MULTIPLY in WebGL in a more expected way. If we decide we want to preserve the existing alpha-ignoring method for everything but text, I can update this code to only use the new blend function when drawing text.
Screenshots of the change:
PR Checklist
npm run lint
passes