try convert remaining to class #6174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test with |
|
Now only Renderer and Renderer2D has problems. |
|
Now that #6244 is merged, this could be fine. Worth pulling in the new changes and checking again maybe? |
asukaminato0721
force-pushed
the
check-fes
branch
from
5680dd3
to
a0e97bd
Compare
asukaminato0721
force-pushed
the
check-fes
branch
from
d45d7ec
to
4481ca6
Compare
asukaminato0721
force-pushed
the
check-fes
branch
from
f521488
to
262b2b6
Compare
|
In test, there is a bug. Renderer.prototype.textSize = function(s) {works textSize (s) {fails. ref 8ce87c8 |
|
Another bug: Renderer2D.prototype.text = function(str, x, y, maxWidth, maxHeight) { // pass
text(str, x, y, maxWidth, maxHeight) { // failref 12dedeb |
asukaminato0721
force-pushed
the
check-fes
branch
from
ba69f22
to
f40c73b
Compare
asukaminato0721
force-pushed
the
check-fes
branch
3 times, most recently
from
bade0ab
to
12dedeb
Compare
|
@davepagurek finished, with two more bugs bypassed. |
limzykenneth
requested changes
Jun 30, 2023
limzykenneth
reviewed
Jul 1, 2023
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
record for #6172
check which class triggers the problem.
Changes:
Screenshots of the change:
PR Checklist
npm run lintpasses