textToContours is broken under textAlign(CENTER,CENTER) and use linebreak #8083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perminder-17
changed the title
davepagurek
reviewed
Sep 12, 2025
src/type/textCore.js
Outdated
| ); | ||
| // When width is not provided (e.g., fontBounds path), fall back to the widest line. | ||
| const maxWidth = boxes.length | ||
| ? boxes.reduce((m, b) => Math.max(m, b.w || 0), 0) |
There was a problem hiding this comment.
Super minor, but I think since you provide the initial value of 0 in the reduce, we don't additionally need to have a ternary on boxes.length; the reduce will already return 0 here.
test/unit/type/p5.Font.js
Outdated
| }); | ||
|
|
||
| test('fontBounds no NaN (multiline + CENTER)', async () => { | ||
| const pFont = await myp5.loadFont(fontFile); |
There was a problem hiding this comment.
Looks like the body of this test might be indented one time too many?
|
Thanks for your valuable feedback :) |
17 tasks
17 tasks
17 tasks
davepagurek
approved these changes
Sep 14, 2025
Always, a pleasure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8079