Skip to content

Feature/8097 get camera function #8105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2,036 commits into
base: main
Choose a base branch
from
Open

Feature/8097 get camera function #8105

wants to merge 2,036 commits into from

Conversation

ombalgude
Copy link

Resolves #8097

Changes:
This pull request introduces a new joint getter/setter function, activeCamera(), to the p5.RendererGL.prototype to standardize how the active camera is accessed and modified.

  1. New activeCamera() function:
  • When called with no arguments (activeCamera()), it acts as a getter and returns the current camera object.
  • When called with a camera object (activeCamera(myCam)), it acts as a setter for the active camera.
  1. Deprecated setCamera():
  • The existing setCamera() function is now deprecated.
  • For backward compatibility, it continues to function by calling the new activeCamera() internally.
  • These changes align with the common p5.js pattern of using joint getter/setter functions and improve the consistency of the WebGL API.

PR Checklist

  • npm run lint passes
  • Inline reference is included / updated
  • Unit tests are included / updated

limzykenneth and others added 30 commits June 29, 2025 23:03
@limzykenneth
Automatically remove DOM event listener on sketch removal
e282432
@limzykenneth
Switch deprecated interface to new supported one
f7150c2
@LalitNarayanYadav
Refactor fn.noise() to use early return guard for cleaner structure
df4c546
@lukeplowden
chipping away at DOD approach.
604c2dd
@perminder-17
Merge pull request processing#7827 from processing/updating-contribut…
63375bb 
…or-docs-for-visual-testing-for-dev-2.0

Updating visual tests docs for 2.x versions
@davepagurek
Skip adding degenerate faces in textToModel
4f81bdb
@lukeplowden
nested ifs
8950817
@LalitNarayanYadav
Bridge p5.js noise with GLSL noise in p5.strands
0cd9448
@LalitNarayanYadav
Add noiseGLSL.glsl with MIT-licensed 2D noise for p5.strands
fd13238
@lukeplowden
if/else semi working
f6369e7
@perminder-17
Merge pull request processing#7951 from processing/fix/textToModel-wa…
3333411 
…rnings

Skip adding degenerate faces in textToModel
@nking07049925
Wrap source string in brackets
aa4de7f
@nking07049925
Add unit test for anonymous function modify hook
547bc8b
@limzykenneth
Await all lifecycle hook functions in parallel
848e619
@perminder-17
Update src/webgl/shaders/functions/noiseGLSL.glsl
27ebbe3
@perminder-17
Merge pull request processing#7921 from LalitNarayanYadav/patch-8
f3ab0ce 
Add GLSL-based noise(vec2) function to p5.strands (processing#7897)
@perminder-17
fixing as per suggestions.
e8cd05c
@Abhayaj247
docs: clarify combineColors and getPointSize documentation per mainta…
06cf619 
…iner feedback
@nking07049925
Add comment with an explanation
dcc31b7
@davepagurek
Fix p5.strands uniform calls, add instance mode construct
98fc10c
@davepagurek
Merge pull request processing#7956 from nking07049925/7955_strands_An…
e4ad5ee 
…onymousFunctionCallbackFix

Fix inline anonymous functions causing a parsing error in p5.strands callbacks
@lukeplowden
change if/elseif/else api to be chainable and functional (return assi…
a355416 
…gnments)
@Abhayaj247
docs: remove getPointSize documentation as it is not present in publi…
1d01ca8 
…c shaders
@LalitNarayanYadav
Enhance strands noise() to support noise(x, y) and add fractal octaves
f300fcf
@LalitNarayanYadav
Add 4-octave fractal noise implementation to noiseGLSL.glsl
b46f73e
@davepagurek
Clean up examples a bit
46842d0
@davepagurek
Merge pull request processing#7961 from processing/fix/strands-unifor…
746a481 
…ms-instance

Fix p5.strands uniform calls, add instance mode construct
@Abhayaj247
Add documentation for remaining public shader hooks in ShaderGenerato…
e73b524 
…r.js
@limzykenneth
Add specific flags to disable individual FES components
ac85b7e
replace fn with direct downloadFile import to fix issue where fn was …
cbb3328 
…not found.
lukeplowden and others added 29 commits September 16, 2025 19:59
@lukeplowden
add instance mode changes, fix bug where struct properties returned i…
2b863e6 
…n hooks didnt cast from float->vec types
@lukeplowden
mark atan as p5 function, prevent bug where using atan outside strand…
6462345 
…s logged a warning
@lukeplowden
add back documentation
37abf7f
@lukeplowden
add todo for internal parser options
f3afffc
@davepagurek
Only copy array when necessary
b31cd28
@davepagurek
Cache bound global functions
4e145ca
@davepagurek
Optimize more matrix and vector things
73b7601
@davepagurek
Optimize some more cases
d0ed1ec
@davepagurek
Cache types and bound functions
8625db9
@davepagurek
Factor out common setter
6b4c3b2
@davepagurek
Merge branch 'dev-2.0' into strands-refactor
d4d968a
@davepagurek
Fix issue with strands being immediately active
bf92d1c
@davepagurek
Add back alias for previous uniformVector2 syntax
a269bd7
@Abhayaj247
Fix: allow single-arg atan() outside strands; add visual test
4a11290
@davepagurek
Optimize further when FES is disabled
795954a
@limzykenneth
Disable FES function decoration when FES is disabled
f88689e
@davepagurek
Merge pull request processing#8094 from processing/global-function-perf
1a86985 
Optimize bottlenecks in 2.0 code
@Abhayaj247
Fix atan unit tests: handle single-arg and two-arg cases, remove visu…
b5021f5 
…al math test
@lukeplowden
add comments for clarity on swizzling and onrebind
18eb43c
@lukeplowden
Merge branch 'strands-refactor' of github.com:lukeplowden/p5.js into …
bae0545 
…strands-refactor
@davepagurek
Parse hookTypes into a strands codegen type
e81920f
@Abhayaj247
Update atan unit tests to comply with maintainer feedback
b2e4e34
@davepagurek
Merge pull request processing#8096 from Abhayaj247/fix/atan-strands
f03d3b5 
Fix: allow single-arg atan() outside strands; add unit test
@davepagurek
Merge branch 'dev-2.0' into strands-refactor
f43770c
@davepagurek
Merge atan test file into trigonometry tests and get it working
ecc8061
@davepagurek
Merge pull request processing#8009 from lukeplowden/strands-refactor
d2cda2a 
[p5.strands] Significant refactor for p5.strands
@davepagurek
Update createCamera docs since it no longer sets the active camera
4036e3a
@ksen0
Merge pull request processing#8100 from processing/update-createcamer…
53c12c3 
…a-docs

Update createCamera docs since it no longer sets the active camera
@ombalgude
feat(webgl) : Add activeCamera() and deprecate setCamera()
e122564
@welcome Welcome
Copy link

welcome bot commented Sep 23, 2025

🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure to add yourself to the list of contributors on the readme page !

Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new getCamera function for V1 & V2