refactor: Move setViewport to standalone addon in lib/addons #8138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Addon libraries should be self hosted and in this case is a test bed for the feature. We can't merge this as we won't be distributing this addon as an official addon. Please see the final section of creating libraries on the p5.js website if you wish to hae the addon listed on the website as a third party addon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! @perminder-17 I've just pushed the requested changes.
Based on your feedback, I've refactored the setViewport feature. It has been removed from the core and is now a standalone addon located at lib/addons/p5.viewport.js, following the convention of other addons in the project.
Thank you for the guidance! Let me know if there's anything else.