Update Manager now shows on startup (resolves #2557) #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfry
added a commit
that referenced
this pull request
Jul 25, 2014
Update Manager now shows on startup (resolves #2557)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix #2557.
What was happening was that the previous hasUpdates() used allContributions, which was of type ArrayList, but actually consisted of a list of AvailableContribution objects, and AvailableContribution.isInstalled() always returns false, which means that the Update Manager would never show because it thought that there was nothing installed.
Now I have used methods in Base and Editor which accurately give all the libs/tools/modes installed.
The checking for updates itself works well without any changes, and needs no modification.