New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Manager now shows on startup (resolves #2557) #2636

Merged
merged 2 commits into from Jul 25, 2014

Conversation

Projects
None yet
2 participants
@joelmoniz
Copy link
Member

joelmoniz commented Jul 12, 2014

This PR is to fix #2557.

What was happening was that the previous hasUpdates() used allContributions, which was of type ArrayList, but actually consisted of a list of AvailableContribution objects, and AvailableContribution.isInstalled() always returns false, which means that the Update Manager would never show because it thought that there was nothing installed.
Now I have used methods in Base and Editor which accurately give all the libs/tools/modes installed.
The checking for updates itself works well without any changes, and needs no modification.

benfry added a commit that referenced this pull request Jul 25, 2014

Merge pull request #2636 from joelmoniz/updateOnStartup
Update Manager now shows on startup (resolves #2557)

@benfry benfry merged commit 5f44e32 into processing:master Jul 25, 2014

@joelmoniz joelmoniz deleted the joelmoniz:updateOnStartup branch Jul 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment