Replacing Hardcoded key-bindings with ones that are modifiable through the settings

[Stefterv]

Most relevant area for this enhancement?

PDE

Feature to enhance

Keybinding

Enhancement details

Enhancement description

A lot of the keys within the PDE are currently hard-coded, we have a system to set up dynamic keybindings but we need help to replace older usages

Benefits

Customising keybindings is important for accessibility as not everyone has a ASCII? based keyboard and some keybindings might be hard to use on other layouts.

Would you like to help implement this enhancement?

No, I’m just suggesting the enhancement

[Stefterv]

An example of hard-coded keybindings:

processing4/java/src/processing/mode/java/JavaEditor.java

Lines 252 to 275 in 275d789

	public JMenu buildSketchMenu() {
	JMenuItem runItem = Toolkit.newJMenuItem(Language.text("menu.sketch.run"), 'R');
	runItem.addActionListener(e -> handleRun());
	JMenuItem presentItem = Toolkit.newJMenuItemShift(Language.text("menu.sketch.present"), 'R');
	presentItem.addActionListener(e -> handlePresent());
	JMenuItem stopItem = new JMenuItem(Language.text("menu.sketch.stop"));
	stopItem.addActionListener(e -> {
	if (isDebuggerEnabled()) {
	Messages.log("Invoked 'Stop' menu item");
	debugger.stopDebug();
	} else {
	handleStop();
	}
	});
	JMenuItem tweakItem = Toolkit.newJMenuItemShift(Language.text("menu.sketch.tweak"), 'T');
	tweakItem.addActionListener(e -> handleTweak());
	return buildSketchMenu(new JMenuItem[] {
	runItem, presentItem, tweakItem, stopItem
	});
	}

[Stefterv]

Examples of not hard-coded bindings

processing4/app/src/processing/app/ui/Editor.java

Lines 804 to 828 in 275d789

	item = Toolkit.newJMenuItemExt("menu.edit.comment_uncomment");
	item.addActionListener(e -> handleCommentUncomment());
	menu.add(item);
	item = Toolkit.newJMenuItemExt("menu.edit.increase_indent");
	item.addActionListener(e -> handleIndentOutdent(true));
	menu.add(item);
	item = Toolkit.newJMenuItemExt("menu.edit.decrease_indent");
	item.addActionListener(e -> handleIndentOutdent(false));
	menu.add(item);
	item = Toolkit.newJMenuItemExt("menu.edit.increase_font");
	item.addActionListener(e -> {
	modifyFontSize(true);
	});
	menu.add(item);
	item = Toolkit.newJMenuItemExt("menu.edit.decrease_font");
	item.addActionListener(e -> {
	modifyFontSize(false);
	});
	menu.add(item);
	menu.addSeparator();

[SableRaf]

@Stefterv This could also use some UI/UX design help 👀

[Stefterv]

You mean as in adding the ability to the settings screen to customise the keybindings?

[SableRaf]

Actually, you're right, since we're redesigning the settings screen anyway, this should be part of that design effort.

[Stefterv]

Yeah I'm also thinking of adding a general text editor for the preferences.txt to the settings screen (or maybe we even said a key-value editor before)