Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warnMixModes temporarily disabled #519

Open
benfry opened this issue Jul 30, 2022 · 3 comments
Open

warnMixModes temporarily disabled #519

benfry opened this issue Jul 30, 2022 · 3 comments
Labels
Help Wanted We have very little time and would like some help High Priority Very high priority and would like to fix ASAP Preprocessor

Comments

@benfry
Copy link
Owner

benfry commented Jul 30, 2022 •
edited

The warnMixedModes section of the Processing.g4 grammar was breaking autocomplete.

(See #491 for that issue)

The commit that caused the breakage is 0f9b290

The temporary workaround is in caf1ba9

This will affect 4.0 beta 9 unless we happen to get a fix before then.
benfry added a commit that referenced this issue Jul 30, 2022
@benfry
disable mixed mode warning; fixes #491, introduces #519
caf1ba9
@benfry benfry added Preprocessor Help Wanted We have very little time and would like some help High Priority Very high priority and would like to fix ASAP labels Jul 30, 2022
This was referenced Jul 30, 2022
Closed
Closed
benfry added a commit that referenced this issue Aug 4, 2022
@benfry
turning off tests because of #519
b681201
@benfry
Copy link
Owner Author

benfry commented Nov 25, 2022

@sampottinger This was a nasty one that I meant to ask you about…

@sampottinger
Copy link
Collaborator

Thanks for catching that @benfry. I should have some time tomorrow. I'll take a look!

@benfry
Copy link
Owner Author

benfry commented Nov 26, 2022

Awesome, thanks!

@benfry benfry mentioned this issue Nov 28, 2022
Merged
@sampottinger sampottinger mentioned this issue Jul 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted We have very little time and would like some help High Priority Very high priority and would like to fix ASAP Preprocessor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sampottinger @benfry