Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Language Server Protocol, Reference Support #684

Closed
Efratror opened this issue Mar 5, 2023 · 4 comments · Fixed by #690
Closed

Feature: Language Server Protocol, Reference Support #684

Efratror opened this issue Mar 5, 2023 · 4 comments · Fixed by #690

Comments

@Efratror
Copy link
Contributor

Efratror commented Mar 5, 2023

Description

Add a feature for supporting references to the LS

Expected Behavior

References are supported by the PDE (find usage). So it would be nice to have it for the server as well

Current Behavior

Only finding declarations is supported at the moment

Your Environment

Possible Causes / Solutions

  • Add static function "searchReference" to the "pdeSymbolFinder" class
  • Use it to find all references using the AST,
  • Send (found) references back to the LS-client

I'm willing to implement this, please assignee me if you're ok with this idea.

@benfry
Copy link
Owner

benfry commented Mar 7, 2023

Yes please, thanks!

@Efratror
Copy link
Contributor Author

@benfry could you please explain what I missed in my previous pr regarding the style sheet? I had read it before placing the pr but clearly I misunderstood some parts of it.

Thanks in advance

@benfry
Copy link
Owner

benfry commented Mar 16, 2023

The main one was things like

if(optionalJavaOffset.isEmpty()){

which should read

if (optionalJavaOffset.isEmpty()) {

but I'd have to check if there were others. Perhaps it wasn't much?

@Efratror
Copy link
Contributor Author

aha thanks, i will try doing better for this PR😊

Efratror added a commit to Efratror/processing4 that referenced this issue Mar 19, 2023
As noted by mr. Fry in PR benfry#678 and issue benfry#684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants