New links in "Help" menu for issues and forum #1210
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added no tests btw. Works bug-free on MacOS 15.6 and should work universally. |
lassevonpfeil
changed the title
catilac
requested changes
Aug 20, 2025
There was a problem hiding this comment.
Hi! Great work on this! I am curious about which version of Java you are using. We use Eclipse Temurin 17. I believe if you set that SDK then you will see that desktop.browse() will throw an exception.
here is an example in the file of the pattern you'll want to follow:
item = new JMenuItem(Language.text("menu.help.getting_started"));
item.addActionListener(e -> Platform.openURL(Language.text("menu.help.getting_started.url")));
menu.add(item);
lassevonpfeil
commented
Aug 20, 2025
catilac
reviewed
Aug 21, 2025
Comment on lines
39
to
41
| import java.net.URI; | ||
| import java.net.URISyntaxException; | ||
|
|
There was a problem hiding this comment.
Are these necessary anymore? If not please remove, and then this is ready to be approved! 🎉
lassevonpfeil
commented
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two links to the help menu bar. Opens either processing forum or GitHub issues tab in standard browser when clicked. Resolves Issue #1208
Implemented the new features in JavaEditor.java and also provided German language support.
Used Desktop.getDesktop() and then Desktop.browse(oURL) to follow the link.
I Placed the MenuItems between "Download official reference" and "library reference".
I will change the code ASAP when somethings bugging or the I messed up with the style guidelines.