InputfieldTextTags throwing error in the admin panel

[lesaff]

Short description of the issue

After updating core to 3.0.175, I've noticed this intermittent behavior (works on some sites but not others). When editing field or template, tabs and their content are not showing up on the page. Console is showing the following error:

Uncaught SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data
    InputfieldTextTags https://localhost:3000/wire/modules/Inputfield/InputfieldTextTags/InputfieldTextTags.min.js?v=1-1619351998:42
    jQuery 2
    InputfieldTextTags https://localhost:3000/wire/modules/Inputfield/InputfieldTextTags/InputfieldTextTags.min.js?v=1-1619351998:40
    <anonymous> https://localhost:3000/wire/modules/Inputfield/InputfieldTextTags/InputfieldTextTags.js:101
    jQuery 11

Expected behavior

Field details should show up (with all the tabs)

Actual behavior

Field details are hidden

This element was not triggered to show due to JS error

.pw-init #ProcessFieldEdit {
    display: none;
}

Looking at the error, it looks like JQuery is trying to find a nonexistent data-opts attribute during a foreach loop (executed by wire/modules/InputfieldTextTags/InputfieldTextTags.min.js) line 39-96, specifically line 42.

var o = JSON.parse($select.attr('data-opts'));

Steps to reproduce the issue

1. Install 3.0.175
2. Edit any field or template

Setup/Environment

Tested on both local environment (using Laravel Valet) and on a staging server running Ubuntu 20.x with RunCloud server manager.

• ProcessWire version:
• (Optional) PHP version: 7.4.x
• (Optional) MySQL version: 5.7.x

[lesaff]

Note: this issue just came out recently (2-3 days). I've updated some sites to 3.0.175 last week and they are fine.

[Toutouwai]

A Modules > Refresh may be required after the latest core update: https://processwire.com/talk/topic/25500-pw-30176-%E2%80%93-core-updates/?do=findComment&comment=213743

[lesaff]

@Toutouwai unfortunately module refresh did not work for my case. It is still returning JS error (see screenshot). The error

[Toutouwai]

I'm getting the same problem when debug mode is off. I think the problem might be in InputfieldTextTags::renderReady() here:

$config->scripts->add($url . 'InputfieldTextTags.js');
$config->styles->add($url . 'InputfieldTextTags.css');

These files named the same as the module don't need to be added because the parent Inputfield::renderReady() method is called which automatically adds those, minified or not according to the debug mode. Commenting out the two lines fixed the issue for me.

[cb2004]

Same issue for me

[csaggo]

+1 one, works on some sites, updated another one today not beeing able to edit field or template

[ryancramerdesign]

I can't duplicate the issue here, but it may be because the extra lines Toutouwai mentioned were removed earlier so maybe that was the issue, though please let me know if still experiencing it.

[lesaff]

@ryancramerdesign whatever changes in those last couple of commits surely fixed it. I am closing this issue. Thanks.

[lesaff]

FYI, the culprit of this particular issue is this module https://github.com/outflux3/SelectizeTemplateFieldTags

As soon as I uninstalled it, the JS error disappeared. I will reach out to @MacRura about this.

[outflux3]

Yes, i posted a few days ago about this. You have to uninstall the module for now, until I work out how to make it compatible.

https://processwire.com/talk/topic/25531-pw-30177-%E2%80%93%C2%A0core-updates/?do=findComment&comment=214042

[ryancramerdesign]

@outflux3 Sorry about that, I wasn't aware of any of this when I added the module to the core, let me know if there's anything I can do on this end that would prevent the issue?

[outflux3]

Hi Ryan, thanks, not sure what can be done; The module initializes the tags field in the same basic way as the core, but the module allows users to enter a list of tags in the module settings, so that differs since the core collects these from the in-use tags (which the module also does); I just need to see how i can now use the core config setting to get those but maybe somehow extend it with the user's list of tags - probably a hook can be used and then the module no longer needs to selectize init that tags field.

[ryancramerdesign]

@outflux3 Sounds good, let me know if you can think of anything. It sounds like your module was already doing some of this stuff before the core module as added, so maybe it would be worthwhile to have any relevant parts of the core (field & template editors or more?) detect if it's present and delegate to your module when it is.