Editing of roles unsets permissions

[processwired]

Short description of the issue

For templates the guest user has no view permission, permissions for these templates get unset for another role if this role is being edited and saved. I had a lot of templates which had no view access for guest (intranet) and killed unintentionally all my view permissions for the other roles :(

Expected behavior

Permissions should stick, should not get overwritten.

Steps to reproduce the issue

1. Create a new template
2. Create a new role, for example with name "testrole".
3. Disable guest view access for template in template's settings. Enable view access for testrole.
4. Head over to masthead -> Permissions -> User roles -> testrole
5. See that page-view is disabled for testrole. If you enable the permission again and save, it doesn't stick.

Setup/Environment

• ProcessWire version: 3.0.88

I can reproduce it, too, same processwire version, no view permission for guest.

The permission on templates for "page-view" is unset in my role (expect home template), so this will unset that permission on all templates after save.
BUT: this can unset system templates too (happened here on a FieldsetPage field), that are not seen on the role.

Added two screenshots for that:

• Opened role and seeing unset templates:
• Save role without any changes will set permissions to a lot of templates (even system templates):

FieldsetPage Field (system template) name is "repeater_default_fields", and there are more unset permissions for it (see screenshot 2): page-edit, page-add, page-create.

After setting templates and saving the permission for the role I can't set it for "repeater_default_fields" (not seen), have to do it directly in the template.

[ryancramerdesign]

Thanks @processwired and @GodMok I've pushed a fix for this issue. Please let me know if you continue to observe any errors with this. Thanks.

Hi @ryancramerdesign , the first part was fixed, normal templates do not loose the permission, but the FieldsetPage Template is loosing it again:

[ryancramerdesign]

@GodMok Repeater templates shouldn't come into play here since they inherit the access control settings of their owning page. But if you've enabled access control on them yourself, I think that might cause the error you are seeing here. I've just pushed an update that should detect this and avoid removing those permissions. Please let me know if you continue to see any errors. Thanks.

Hi @ryancramerdesign, it is working now. Sorry for the very long delay.