Tab fields not working in profile edit screen

[gebeer]

Short description of the issue

Custom Tab fields in user templates are not being displayed correctly on the profile edit screen:

Expected behavior

Tabs show correctly as in the page edit screen

Actual behavior

Tabs display as normal fieldsets

Steps to reproduce the issue

1. add a FieldsetTabOpen and FieldsetTabClose to the user template
2. add some custom fields inside the tabs
3. configure module ProcessProfile to include the tabs and custom field on the profile edit page
4. Go to profile edit screen

Setup/Environment

• ProcessWire version: 3.0.96
• (Optional) PHP version: 5.6

[gideonso]

I do the same and it is no problem at all.

[gebeer]

@gideonso your screenshot looks like you are not on the profile edit screen but on Access->Users->user
Edit from /youradminurl/profile and you will see that tabs are not working

[gebeer]

I just got pointed to #538 from the forum and saw Ryan's comments there.

Still I do not understand why displaying tabs could be a security issue.

[ryancramerdesign]

In the case of tabs it's not a security issue. It's just that the Profile editor doesn't have tab support. If present, they would render as fieldsets in ProcessProfile. The page editor needs tabs because it has specific Content, Children, Settings, and Delete tabs. None of these are applicable to the Profile editor, which is just a single screen. There's quite a bit of code involved to convert TabOpen/TabClose fields to InputfieldWrapper.WireTab elements, and that isn't present in ProcessProfile at this time. Feasibly it could be added, but it's one of those things that would take a lot of code to accomplish and I'm not sure it's worthwhile at this point. If a lot of people need it down the road we can always add it.

[szabeszg]

Tabs on Profile editor page:

If a lot of people need it down the road we can always add it.

I would like to use them too if it was possible.
Anyone also needing it can +1 this post in order to see the interest :)

[teppokoivula]

@szabeszg made it here first, but I've also had a similar need.

There's quite a bit of code involved to convert TabOpen/TabClose fields to InputfieldWrapper.WireTab elements, and that isn't present in ProcessProfile at this time. Feasibly it could be added, but it's one of those things that would take a lot of code to accomplish and I'm not sure it's worthwhile at this point.

Isn't there a way to abstract the code mentioned above, so that tabs could be used in Page editor, Profile editor, and potentially elsewhere as well? Not sure what that "elsewhere" would include, though.. but front-end use maybe? Just thinking out loud here :)

[ethanbeyer]

@teppokoivula I've been hoping for some of that abstraction in #538 as well; there's a lot of (edit: similar) code that handles ProcessPageEdit and ProcessProfileEdit, and I can see the necessity behind their separation, but I would love if the ProfileEdit was as and built the same way as PageEdit.

[gebeer]

@ryancramerdesign Thank you for the explanation.
After reading your comment on #538 I understand that the profile edit screen is not meant to be used as a fully featured page edit screen.
But still, for directory type of sites where lots of users log on to edit their personal data, the profile edit process would be a safe place to do that. Since it is lacking a lot of functionality from the page edit process, we currently need to workaround for those scenarios which involves quite a lot of planning and coding.
Also, sending users to the page edit screen at /access/users/edit/?id=xxxx is not so nice because they might get the idea to change the id param in the URL and see what happens etc. So we need to cater for that and keep the users out of parts in the backend with redirection hooks or the like.
To avoid this, I tried to execute the page edit process under a custom URL in a custom process module, but couldn't get that to work either see forum post here because of the redirection happening in ProcessPageEdit::___loadPage().
It would really be nice to be able to have a safe place in the backend where users can edit their profiles with all functionality that the page edit process brings.

[Backoo]

I add myself to the list of people saying that it would be appropriate to allow logged in users to edit their profile almost the same way as they can make with other PW pages. Hoping to get a (definitive) solution, a new post on the PW forum has been made.

[netcarver]

@ryancramerdesign Ryan, should this be considered a feature request?

[ryancramerdesign]

@netcarver Yes, I think this would be fine in the feature requests. If we do a rewrite of the ProcessProfile module at some point in the future then we could add support for these tabs. I usually search the requests repo when doing any major refactoring of any particular module/class.