Required only if with required field action issue

[PWaddict]

Short description of the issue

On my template's "Required field action" is set to Unpublish the page. I have a Page Table field inside that template with the condition "Required only if". So when a checkbox is checked the Page Table field is required.

The problem is that if the checkbox is unchecked so the Page Table isn't required when I save the page it gets unpublished with the error: "Session: Page unpublished because field "test_pagetable" is required" then I can publish the page again without issues then if I save the page again it gets unpublished with the above error and so on...

Setup/Environment

• ProcessWire version: 3.0.98
• (Optional) PHP version: 7.0.18

[Toutouwai]

This issue applies to both the "Restore the previous value" and "Unpublish the page" actions in "Required field action" setting. It affects any required-if field, not just PageTable fields.

It looks like this part of ProcessPageEdit doesn't account for required-if conditions, and performs the actions whenever the "required" setting is applied to a field that is submitted empty.

[PWaddict]

I fixed it by replacing the 1585 line of ProcessPageEdit.module with this:

&& $inputfield->getSetting('required') && !$inputfield->getSetting('requiredIf') && $inputfield->isEmpty()

@ryancramerdesign please check the fix and include it on the next dev.

[Toutouwai]

I fixed it by replacing the 1585 line of ProcessPageEdit.module with this

That won't fix it because then the action won't trigger when the required-if condition evaluates true. The solution will have to involve the evaluation of required-if conditions.

[PWaddict]

You're right.

[ryancramerdesign]

Thanks for the report. I think I know where the issue is here. Can you try editing the /wire/modules/Inputfield/InputfieldForm.module and modifying something? Line 372 is currently this:

if(self::debug) $this->debugNote("$child->name - determined that value is not required");

Modify it by adding another line below it:

if(self::debug) $this->debugNote("$child->name - determined that value is not required");
$child->set('required', false); // add this line

What the above does is just updates the required state of the Inputfield when it's already been determined that it's not required due to evaluation of a requiredIf. That should enable ProcessPageEdit to see it.

[PWaddict]

@ryancramerdesign Still same issue :(

[Toutouwai]

@ryancramerdesign, your fix is working for me.

[PWaddict]

@Toutouwai You can save the already published page without getting it unpublished?

[PWaddict]

@ryancramerdesign @Toutouwai The above fix indeed it works BUT if I want to also use the show if on the same field with the required only if to display the field ONLY when it's required then it doesn't work.

[PWaddict]

@ryancramerdesign I fixed the show if issue. After we added the above fix then on /wire/modules/Inputfield/InputfieldForm.module 272 line there is this:

$child->set('showIfSkipped', true); // flag the field as skipped

I added below it this:

$child->set('required', false);

[ryancramerdesign]

I was just re-thinking my approach about changing the value of required might not be quite right, because it's possible someone render()'s the form after the processInput. In that case, the field would no longer be required. Most of the time this would not be a problem, as one would redirect back to the current page after form processing, but I can't assume that. As a result, I've got to use a separate property to indicate that we can skip the required state. The latest commit adds that. Also, this includes something to account for the issue you mentioned above with showIfSkipped as well. Can you tell if this also fixes it? Thanks.

[PWaddict]

@ryancramerdesign Both are working properly. Thank you very much. Should I close the issue?

[ryancramerdesign]

Great, thanks for testing. I will close this.