"Trash for all" feature does not work if the 404 page is moved under "admin"

[theo222]

Short description of the issue

"Trash for all" feature does not work if the 404 page is moved under "admin"-
If 404 page ist moved back under "home", the trash icon is showing up for the non-superuser.

Expected behavior

No dependency on location of 404 page.

See also: https://processwire.com/talk/topic/20902-trash-for-all-does-it-work/?tab=comments#comment-181000

PW Version 3.0.123

[reminders]

@netcarver set a reminder for Feb 27th 2019

[reminders]

👋 @netcarver, review this issue

[ryancramerdesign]

@theo222 The 404 page is a page like any other in the system when it comes to access control. If you move the page to somewhere that requires a login (which the admin does), that's going to potentially break ProcessWire's ability to properly render 404s and could cause a lot of other problems, the least of which is probably the effect on the trash. It's okay to move the 404 page to another location if you want to, but do not move it into the admin and don't move it below some other access controlled parent. Your 404 page needs to be publicly accessible since it loaded and rendered any time a requested URL is not found.

[theo222]

Thank you!

[theo222]

Reopened because the 404 page affects "trash for all" even if not moved under admin but also when hidden using: $wire->addHookAfter('Page::listable',...

So there is still no way to let the editor see the trashcan while the 404 page is hidden.

[matjazpotocnik]

It's in ProcessPageListRenderJSON.php:

foreach($this->children as $page) {
	if(!$this->superuser && !$page->listable()) continue;

	if($page->id == $id404 && !$this->superuser) {
		// allow showing 404 page, only if it's editable
		$page404 = $page;
		if(!$page->editable()) continue;
	} else if(in_array($page->id, $this->systemIDs)) {
		if($this->superuser) $extraPages[$page->id] = $page;
		continue;
	}

	$child = $this->renderChild($page);
	$children[] = $child;
}

if(!$this->superuser && $page404 && $page404->parent_id == 1 && !isset($extraPages[$idTrash])) {
	$pageTrash = $this->wire('pages')->get($idTrash);
	if($pageTrash->id && $this->getUseTrash() && $pageTrash->listable()) {
		$extraPages[$pageTrash->id] = $pageTrash;
	}
}

Commenting $page404 && $page404->parent_id == 1 makes Trash appear in the list. Why is page404 so important in displaying Trash is not clear to me, Ryan will have to explain.

[ryancramerdesign]

@matjazpotocnik @theo222 I'm not sure about the 404 dependency either but as far as I can tell it is not necessary. I have adjusted the code to remove the 404 dependency so it should work now. Thanks.