Use step attribute = precision in float inputfield if html5 number

[pine3ree]

When using FieldtypeFloat its input fields should have a step attribute matching the field precision. This still allows any number of decimals, only change the step from the default "1" to the more related "precision" value. Since the decimal fieldtype already supported it, the code was moved to the float inputfield when rendering the html attributes and applied only when a positive precision is set.

[ryancramerdesign]

@pine3ree Thanks, I will add this. One question though: it looks like it adds the step attribute regardless of whether the inputType is 'number' or 'text'. Shouldn't the "step" attribute be omitted if the inputType is text? If you agree, don't worry about updating the PR as I can add that myself, but just wanted to double check in case the omission was intentional?

[pine3ree]

Hello @ryancramerdesign ,

in getAttributesString the 1st line checks for it:

if($attributes && $attributes['type'] === 'number') { 

so the step attribute is added only when the attribute 'type' is 'number'
kind regards

(PS. edited)
...so the step attribute is only added on-the-fly when generating and rendering the html-attributes..

[ryancramerdesign]

@pine3ree Okay thanks I understand now (that context wasn't visible on the 'Files changed' tab here).

One other question, it seems like the if(!isset($attributes['step'])) line could never resolve true, since the step attribute has a default value of any, established in InputfieldFloat::init() ? I think I can correct that by changing it to this, below but wanted to make sure I'm not missing something or breaking something you intended?

if(empty($attributes['step']) || $attributes['step'] === 'any') { 

[pine3ree]

Hello @ryancramerdesign ,

yes, correct, sorry, I had added that to my current project and forgot to add it back to my gh-fork. The purpose is obviously to add a default step based on precision, if not set programmatically (e.g. $myInputField->attr('step', '0.05').

[ryancramerdesign]

Thanks @pine3ree I have added this.

[matjazpotocnik]

@pine3ree can you close this PR?