-
-
Notifications
You must be signed in to change notification settings - Fork 175
Add Travis CI tests for Laravel 5.4 #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Travis CI tests for Laravel 5.4 #257
Conversation
antonkomarev
commented
Jul 9, 2017
- Add Travis CI tests for Laravel 5.4
- Cleanup test composers contents
build fail :( |
It's not completely failing. Laravel 5.4 is working. The main goal of this PR is add automated Laravel 5.4 testing. Return support of Laravel 5.3 and lower will be the next step. |
so the main package is now 5.4 compatible? or is it dev-master that supports 5.4 |
Only |
let me update and check i pray the array validation has been fixed magically |
@akkhan20 sure! I've just finished this PR. Waiting that all Travis jobs comple and ready for merge. We are waiting to have success result for Laravel 5.4 tests only! |
the package is not generating the js rule for var.* => 'min:5|max:15' where as when i dug in previously reported issues i see the package owner stating that this issue has been fixed and functional in latest package |
the rule in laravel is like: but the rule generated in js is: |
@akkhan20 You'd better place it in proper issue: #253 |