Skip to content

Conversation

antonkomarev
Copy link
Contributor

  • Add Travis CI tests for Laravel 5.4
  • Cleanup test composers contents

@jampack
Copy link

jampack commented Jul 9, 2017

build fail :(

@antonkomarev
Copy link
Contributor Author

It's not completely failing. Laravel 5.4 is working. The main goal of this PR is add automated Laravel 5.4 testing. Return support of Laravel 5.3 and lower will be the next step.

@jampack
Copy link

jampack commented Jul 9, 2017

so the main package is now 5.4 compatible? or is it dev-master that supports 5.4

@antonkomarev
Copy link
Contributor Author

@antonkomarev
Copy link
Contributor Author

Only dev-master is supporting Laravel 5.4. And it's not supporting any older Laravel versions.

@jampack
Copy link

jampack commented Jul 9, 2017

let me update and check i pray the array validation has been fixed magically

@antonkomarev
Copy link
Contributor Author

antonkomarev commented Jul 9, 2017

@akkhan20 sure! I've just finished this PR. Waiting that all Travis jobs comple and ready for merge. We are waiting to have success result for Laravel 5.4 tests only!

@jampack
Copy link

jampack commented Jul 9, 2017

the package is not generating the js rule for var.* => 'min:5|max:15' where as when i dug in previously reported issues i see the package owner stating that this issue has been fixed and functional in latest package

@antonkomarev antonkomarev merged commit 0e64516 into proengsoft:master Jul 9, 2017
@antonkomarev antonkomarev deleted the feature/add-laravel-5.4-tests branch July 9, 2017 19:05
@jampack
Copy link

jampack commented Jul 9, 2017

the rule in laravel is like:
'description' => 'required|min:30:max:500', 'tasks.*' => 'min:10|max:65500'

but the rule generated in js is:
rules: {"description":{"laravelValidation":[["Required",[],"Description is required",true],["Min",["30:max:500"],"Description too short(minimum 30 characters)",false]]}} })

@antonkomarev
Copy link
Contributor Author

@akkhan20 You'd better place it in proper issue: #253
This one related to Travis tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants