Skip to content

Conversation

sandersk
Copy link
Contributor

Hi @networm,

I've escaped the quotation marks in the attribute block for this image:: markup:

image::images/vs-2.png[Visual Studio 中的 Git 仓库的 "Home" 视图。]

Which should correct the build error for the book.

Hope this helps,
Sanders

@networm
Copy link
Member

networm commented Aug 17, 2015

@sandersk Sorry, we need to change quotation mark to full width. So I created another PR to fix this.

@networm
Copy link
Member

networm commented Aug 17, 2015

@sandersk Thank you very much! We have passed building! Pro Git build progress

@networm networm closed this Aug 17, 2015
@oldsharp
Copy link
Contributor

We could have cherry-picked 77b8812 , then either amend it or add a new commit on top of it.
If we had done that, then #243 might not have to be opened.

@networm networm reopened this Aug 17, 2015
@networm networm merged commit 77b8812 into progit:master Aug 17, 2015
@networm
Copy link
Member

networm commented Aug 17, 2015

@sandersk We have merged your Pull Request.
@oldsharp I have merged it.

OlingCat pushed a commit to OlingCat/progit2-zh that referenced this pull request Mar 6, 2020
small grammar fix: it have -> it has
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants