Performance improvements #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should eliminate overhead when calling same key over and over again. I should also improve performance when accessins keys that return `nil` - those were handled improperly before.
Open
pnikrat
reviewed
Nov 3, 2020
pnikrat
reviewed
Nov 3, 2020
pnikrat
approved these changes
Nov 3, 2020
| @@ -130,7 +139,7 @@ def store_item(locale, data, scope = [], startup_process = false) | |||
| # end | |||
| elsif data.respond_to?(:to_str) || data.is_a?(Array) | |||
| key = ([locale] + scope).join('.') | |||
| return if startup_process && @cache.keys.member?(key) && Lit.ignore_yaml_on_startup | |||
| return if startup_process && Lit.ignore_yaml_on_startup && (Thread.current[:lit_cache_keys] || @cache.keys).member?(key) | |||
There was a problem hiding this comment.
This store_item method looks too messy to me. Maybe you could 1. remove commented transaction block 2. extract this lengthy conditional to separate method? However this would require handling startup_process variable differently. To be honest if startup_process is true most of this method is skipped entirely. Maybe startup_process can live in Lit.startup_process?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should eliminate overhead when calling same key over and over
again. I should also improve performance when accessins keys that return
nil- those were handled improperly before.