Skip to content

Conversation

pnikrat
Copy link
Contributor

@pnikrat pnikrat commented Nov 4, 2021

Adjust code so that we can support both V1 and V2 gem versions of Google Cloud translate.

Bonus:

@pnikrat
Copy link
Contributor Author

pnikrat commented Nov 4, 2021

Failure:
WelcomeTest#test_shoud_properly_save_default_value [/lit/test/integration/lit/welcome_test.rb:109]:
Expected false to be truthy.


Failure:
WelcomeControllerTest#test_should_properly_store_key_with_default_value [/lit/test/functional/welcome_controller_test.rb:36]:
Expected: nil
  Actual: "Default content"

Maciej, I'm having trouble with those two tests. They only fail on Rails 6.1 Appraisal. I know default translation content was fuc*ked up in Rails 6.1 upstream but it was supposed to be fixed by now? I've updated Appraisal to use newest Rails 6.1 patch. Any ideas?

It's working nicely now

@pnikrat pnikrat marked this pull request as ready for review November 4, 2021 17:44
@pnikrat pnikrat requested a review from mlitwiniuk November 4, 2021 17:44
@pnikrat
Copy link
Contributor Author

pnikrat commented Dec 17, 2021

@mlitwiniuk Added most recent changes

@pnikrat pnikrat merged commit 7ca3e49 into master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants