Implement metrics #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radka-j
changed the title
tallamjr
added a commit
that referenced
this pull request
Oct 2, 2019
It was discovered in builds from #79 and #78 a failure has occurred on Travis Error: TypeError: attrib() got an unexpected keyword argument 'convert' It appears that pytest seems to have the package attrs as a dependency. REF: https://stackoverflow.com/questions/58189683/typeerror-attrib-got-an-unexpected-keyword-argument-convert modified: requirements.txt
|
TO DO:
|
tallamjr
referenced
this pull request
in project-bluebird/bluebird
Oct 16, 2019
It was discovered in builds from https://github.com/alan-turing-institute/dodo/pull/79 and https://github.com/alan-turing-institute/dodo/pull/78 a failure has occurred on Travis Command: $ pytest -rs --ignore=./tests/integration ./tests Error: TypeError: attrib() got an unexpected keyword argument 'convert' It appears that pytest seems to have the package attrs as a dependency. REF: https://stackoverflow.com/questions/58189683/typeerror-attrib-got-an-unexpected-keyword-argument-convert modified: requirements.txt
tallamjr
referenced
this pull request
in project-bluebird/bluebird
Oct 16, 2019
It was discovered in builds from https://github.com/alan-turing-institute/dodo/pull/79 and https://github.com/alan-turing-institute/dodo/pull/78 a failure has occurred on Travis Command: $ pytest -rs --ignore=./tests/integration ./tests Error: TypeError: attrib() got an unexpected keyword argument 'convert' It appears that pytest seems to have the package attrs as a dependency. REF: https://stackoverflow.com/questions/58189683/typeerror-attrib-got-an-unexpected-keyword-argument-convert modified: requirements.txt
tallamjr
referenced
this pull request
in project-bluebird/bluebird
Oct 16, 2019
It was discovered in builds from https://github.com/alan-turing-institute/dodo/pull/79 and https://github.com/alan-turing-institute/dodo/pull/78 a failure has occurred on Travis Command: $ pytest -rs --ignore=./tests/integration ./tests Error: TypeError: attrib() got an unexpected keyword argument 'convert' It appears that pytest seems to have the package attrs as a dependency. REF: https://stackoverflow.com/questions/58189683/typeerror-attrib-got-an-unexpected-keyword-argument-convert modified: requirements.txt [SQUASH] Moving pytest bump to requirements-dev instead Since pytest is only a requirement for development, it should reside in 'requirements-dev.txt' file instead of the main 'requirements.txt' file modified: requirements-dev.txt modified: requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue
loss_of_separation()metric