Skip to content

Conversation

PabloCarmona
Copy link
Contributor

No description provided.

@starpit
Copy link
Collaborator

starpit commented Jun 30, 2022

  1. https://www.npmjs.com/package/pretty-bytes
  2. our memory comes in kilobytes, as you can see from the current /1024/1024 GiB logic

@PabloCarmona
Copy link
Contributor Author

i'll follow the use of the npm package that bring us a more flexible use of the presentation of the bytes, but we keep it as a low priority for now.

@starpit starpit marked this pull request as draft June 30, 2022 13:26
starpit added a commit to starpit/codeflare-cli that referenced this pull request Jul 6, 2022
we should use a real memory pretty printer

Closes project-codeflare#208
@starpit starpit closed this in #248 Jul 6, 2022
starpit added a commit that referenced this pull request Jul 6, 2022
we should use a real memory pretty printer

Closes #208
PabloCarmona pushed a commit to PabloCarmona/codeflare-cli that referenced this pull request Jul 7, 2022
we should use a real memory pretty printer

Closes project-codeflare#208
@PabloCarmona PabloCarmona deleted the prettify-bytes branch August 1, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants