Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing roles to create ClusterRoleBinding for CodeFlare operator #509

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Apr 11, 2024

Cleanup after MCAD removal

Issue link

https://issues.redhat.com/browse/RHOAIENG-5297

What changes have been made

Refactored and cleaned controller RBAC permissions.

Verification steps

Install CFO as a dedicated operator using OLM:

  • export custom VERSION and IMAGE_ORG_BASE env variable, pointing to your registry and your version.
    make image-build
    make image-push
    make bundle-build
    make bundle-push
    make catalog-build
    make catalog-push
  • create own OpenShift/OLM CatalogSource pointing to your built catalog
  • Install CodeFlare operator from added catalog
  • Use the CFO together with other components and SDK to spin up Ray cluster.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@Fiona-Waters
Copy link
Contributor

Ran this on my openshift cluster along with codeflare-sdk main branch and kueue, and it works as expected. I was able to successfully create a ray cluster using a demo notebook. Thanks @sutaakar for allowing me to use your catalog image.
/lgtm

@sutaakar
Copy link
Contributor Author

/approve

Copy link

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 58b23ee into project-codeflare:main Apr 12, 2024
7 checks passed
@sutaakar sutaakar deleted the crb branch April 12, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants